Publish get-dotnetup scripts alongside dotnetup#17053
Merged
Merged
Conversation
The aka.ms links hosting scripts as they are today point to a raw github endpoint which is not sustainable practice and does not allow for signing of the scripts (which is needed to prevent them from being blocked by default on powershell.) dotnet/sdk#54984 This PR adds the scripts to the published dotnetup output while the arcade change here will actually consume and ensure that those scripts also get published as aka.ms links using the same channel `\daily\`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Arcade’s feed publishing configuration so get-dotnetup bootstrap scripts (.ps1 / .sh, plus .sha512) are eligible for aka.ms “latest” link creation alongside existing dotnetup binaries, enabling signed, versioned script hosting instead of raw GitHub URLs.
Changes:
- Extend
DotnetupAkaMSCreateLinkPatternsto includeget-dotnetup.{ps1,sh}(and checksums). - Add unit coverage validating dotnetup channel link-pattern behavior and link creation outputs.
- Minor whitespace cleanup in
PublishingConstants.cs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Build.Tasks.Feed/src/model/PublishingConstants.cs | Adds aka.ms link-matching regex for get-dotnetup scripts and ties it to the dotnetup daily channel. |
| src/Microsoft.DotNet.Build.Tasks.Feed.Tests/LatestLinksManagerTests.cs | Verifies LatestLinksManager creates expected aka.ms links for dotnetup binaries + get-dotnetup scripts only. |
| src/Microsoft.DotNet.Build.Tasks.Feed.Tests/GeneralTests.cs | Confirms dotnetup channel config allows intended assets and rejects unrelated scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
13 tasks
mmitche
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aka.ms links hosting scripts as they are today point to a raw github endpoint which is not sustainable practice and does not allow for signing of the scripts (which is needed to prevent them from being blocked by default on powershell.)
dotnet/sdk#54984 This PR adds the scripts to the published dotnetup output while the arcade change here will actually consume and ensure that those scripts also get published as aka.ms links using the same channel
\daily\