Ensure we test on TFMs that have unique RID-specific assets#7470
Merged
ViktorHofer merged 1 commit intodotnet:mainfrom Jun 5, 2021
Merged
Ensure we test on TFMs that have unique RID-specific assets#7470ViktorHofer merged 1 commit intodotnet:mainfrom
ViktorHofer merged 1 commit intodotnet:mainfrom
Conversation
Anipik
approved these changes
Jun 5, 2021
ViktorHofer
approved these changes
Jun 5, 2021
Member
|
Nit: Isn't the rid part now dead code? |
Member
Author
|
RID part is not dead yet, not until I merge my PR. This is needed regardless because it makes sure we test frameworks that will have RID-specific runtime targets. I noticed that when testing my PR. Once my PR is merged to runtime we can delete the RID part of this. |
Member
|
Works for me 👍 |
Contributor
|
i have a pr in pipeline which remodels everything, i can delete the rid as part of it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing cases where the RID-specific asset had a different framework than RID agnostic. As a result we wouldn't test all TFMs that had different assets.
https://github.com/dotnet/runtime/blob/d40dc6eb1398f25d083a818436c54810917e2147/src/libraries/System.Speech/src/System.Speech.csproj#L4
https://github.com/dotnet/runtime/blob/d40dc6eb1398f25d083a818436c54810917e2147/src/libraries/System.Diagnostics.EventLog/src/System.Diagnostics.EventLog.csproj#L4