Normalize Uris when writing manifests#7521
Merged
michellemcdaniel merged 5 commits intodotnet:mainfrom Jun 15, 2021
Merged
Conversation
For each manifest, we should normalize the Azure DevOps uris, so that differences between machine state do not affect merging the manifests down the line. We will normalize the AzureDevOpsRepository and the InitialAssetsLocations, if found in the attributes.
ghost
requested review from
|
Can we add tests for this to https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/BuildModelFactoryTests.cs? |
Contributor
Author
|
I wasn't sure exactly how to fit it in, but I will try. |
ghost
reviewed
Jun 14, 2021
Contributor
Author
|
Updated the tests with the new normalization info. |
epananth
approved these changes
Jun 14, 2021
ghost
approved these changes
Jun 14, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each manifest, we should normalize the Azure DevOps uris, so that differences between machine state do not affect merging the manifests down the line. We will normalize the AzureDevOpsRepository and the InitialAssetsLocations, if found in the attributes.
Fixes #7493.
To double check: