Add ExponentialRetry to FindDotNetCliPackage task#7882
Merged
MattGal merged 1 commit intodotnet:mainfrom Sep 10, 2021
Merged
Conversation
…ional, the productVersion.txt stuff needs to succeed.
ghost
approved these changes
Sep 10, 2021
MattGal
added a commit
to MattGal/arcade
that referenced
this pull request
Sep 13, 2021
…ional, the productVersion.txt stuff needs to succeed. (dotnet#7882)
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally implemented this with the feature being optional, but the combination of being the default behavior and adding more httpClient calls, I have seen at least one Http Client timeout fail sending to helix; since it's not optional, the productVersion.txt stuff needs to succeed.
#7836
To double check: