Rename resource relationship methods to reference relationship for consistency - #8432
Merged
David Fowler (davidfowl) merged 2 commits intoMar 31, 2025
Merged
Conversation
David Fowler (davidfowl)
requested review from
James Newton-King (JamesNK) and
Copilot
March 31, 2025 07:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
Renames methods to improve consistency by replacing "WithResourceRelationship" with "WithReferenceRelationship" across multiple files.
- Updated method calls in ResourceBuilderExtensions.cs, ConnectionStringBuilderExtensions.cs, and AzureBicepResourceExtensions.cs.
- Renamed method definitions and their invocations to reflect the new naming convention.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting/ResourceBuilderExtensions.cs | Replaced method calls and definitions from WithResourceRelationship to WithReferenceRelationship. |
| src/Aspire.Hosting/ConnectionStringBuilderExtensions.cs | Updated invocation to use WithReferenceRelationship. |
| src/Aspire.Hosting.Azure/AzureBicepResourceExtensions.cs | Modified method calls to invoke WithReferenceRelationship instead of WithResourceRelationship. |
github-actions
Bot
added
the
area-app-model
James Newton-King (JamesNK)
approved these changes
Mar 31, 2025
David Fowler (davidfowl)
deleted the
davidfowl/rename-relationship-method
branch
March 31, 2025 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename WithResourceRelationship to WithReferenceRelationship