Skip to content

Conversation

@MattKotsenas
Copy link
Member

Description

Remove the default memory limit from the Kusto emulator; setting the limit too low can result in errors when running big queries / ingestion, so devs should set the value if needed.

Added tests to verify that all the default emulator values are covered.

Contributes to #8233.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings September 26, 2025 00:05
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11666

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11666"

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Sep 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the default 4GB memory limit from the Kusto emulator container configuration to prevent errors during large queries or data ingestion operations, allowing developers to set memory limits as needed.

Key changes:

  • Removed hardcoded "--memory=4G" container runtime argument from the emulator configuration
  • Added comprehensive tests to verify emulator configuration and ensure all default values are properly tested

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Aspire.Hosting.Azure.Kusto/AzureKustoBuilderExtensions.cs Removed the default memory limit container runtime argument
tests/Aspire.Hosting.Azure.Kusto.Tests/AddAzureKustoTests.cs Enhanced tests with async methods, added EULA verification test, and created helper extensions for testing annotations

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 26, 2025
@eerhardt eerhardt merged commit 8b5aa09 into dotnet:main Sep 26, 2025
312 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.6 milestone Sep 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants