Skip to content

Remove memory limit from Kusto emulator #11666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

Remove memory limit from Kusto emulator #11666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da53acc
Remove memory limit from Kusto emulator
MattKotsenas Sep 25, 2025
4b6e04e
Add test to verify setting memory limit
MattKotsenas Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Aspire.Hosting.Azure.Kusto/AzureKustoBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,7 @@ public static IResourceBuilder<AzureKustoClusterResource> RunAsEmulator(
Image = AzureKustoEmulatorContainerImageTags.Image,
Tag = AzureKustoEmulatorContainerImageTags.Tag
})
.WithEnvironment("ACCEPT_EULA", "Y")
.WithContainerRuntimeArgs("--memory", "4G");
.WithEnvironment("ACCEPT_EULA", "Y");

configureContainer?.Invoke(surrogateBuilder);

Expand Down
48 changes: 45 additions & 3 deletions tests/Aspire.Hosting.Azure.Kusto.Tests/AddAzureKustoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using Aspire.Hosting.ApplicationModel;
using Aspire.Hosting.Testing;
using Aspire.Hosting.Utils;

namespace Aspire.Hosting.Azure.Kusto.Tests;
Expand Down Expand Up @@ -88,7 +89,7 @@ public void RunAsEmulator_ShouldAddEmulatorResourceAnnotation()
}

[Fact]
public void RunAsEmulator_RespectsConfigurationCallback()
public async Task RunAsEmulator_RespectsConfigurationCallback()
{
// Arrange
using var builder = TestDistributedApplicationBuilder.Create();
Expand All @@ -97,12 +98,33 @@ public void RunAsEmulator_RespectsConfigurationCallback()
var resourceBuilder = builder.AddAzureKustoCluster("kusto").RunAsEmulator(builder =>
{
builder.WithAnnotation(new ContainerNameAnnotation() { Name = "custom-kusto-emulator" });
builder.WithContainerRuntimeArgs("--memory", "4G");
});

// Assert
var annotation = resourceBuilder.Resource.Annotations.OfType<ContainerNameAnnotation>().SingleOrDefault();
var nameAnnotation = resourceBuilder.Resource.Annotations.OfType<ContainerNameAnnotation>().SingleOrDefault();
Assert.NotNull(nameAnnotation);
Assert.Equal("custom-kusto-emulator", nameAnnotation.Name);

var argsAnnotation = resourceBuilder.Resource.Annotations.OfType<ContainerRuntimeArgsCallbackAnnotation>().SingleOrDefault();
Assert.NotNull(argsAnnotation);
Assert.Equivalent(new[] { "--memory", "4G" }, await argsAnnotation.GetContainerRuntimeArgs());
}

[Fact]
public async Task RunAsEmulator_SetsEula()
{
// Arrange
using var builder = TestDistributedApplicationBuilder.Create();

// Act
var resourceBuilder = builder.AddAzureKustoCluster("kusto").RunAsEmulator();

// Assert
var annotation = resourceBuilder.Resource.Annotations.OfType<EnvironmentCallbackAnnotation>().SingleOrDefault();
Assert.NotNull(annotation);
Assert.Equal("custom-kusto-emulator", annotation.Name);
var env = await builder.GetEnvironmentVariables(annotation);
Assert.Equivalent(new Dictionary<string, object>() { { "ACCEPT_EULA", "Y" } }, env);
}

[Theory]
Expand Down Expand Up @@ -353,3 +375,23 @@ public void WithHostPort_ShouldThrowArgumentNullException_WhenBuilderIsNull()
Assert.Equal("builder", exception.ParamName);
}
}

file static class TestingExtensions
{
public static async Task<Dictionary<string, object>> GetEnvironmentVariables(this IDistributedApplicationTestingBuilder builder, EnvironmentCallbackAnnotation annotation)
{
var context = new EnvironmentCallbackContext(builder.ExecutionContext);
await annotation.Callback(context);

return context.EnvironmentVariables;
}

public static async Task<IList<object>> GetContainerRuntimeArgs(this ContainerRuntimeArgsCallbackAnnotation annotation)
{
var results = new List<object>();
var context = new ContainerRuntimeArgsCallbackContext(results);
await annotation.Callback(context);

return context.Args;
}
}
Loading