-
Notifications
You must be signed in to change notification settings - Fork 801
Add dashboard URL to pipeline summary for ACA and App Service deployments #14377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14377Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14377" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds Aspire dashboard URLs to the pipeline deployment summary for Azure Container Apps (ACA) and Azure App Service environments, so the dashboard link appears in the post-deploy PipelineSummary (similar to the Docker Compose pattern introduced in #14367).
Changes:
- Add
context.Summary.Add("📊 Dashboard", ...)to ACA environment print-summary step. - Add
context.Summary.Add("📊 Dashboard", ...)to App Service environment print-summary step with a null/empty guard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs | Adds the dashboard URL to PipelineSummary during the print-summary step. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs | Adds the constructed ACA dashboard URL to PipelineSummary during the print-summary step. |
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs:156
- If
dashboardUriis null/empty/whitespace, this will still reportDashboard available at []()which is misleading. Consider returning early (or emitting a different completion message) when the dashboard URL isn’t available so the step output stays accurate.
await context.ReportingStep.CompleteAsync(
$"Dashboard available at [{dashboardUri}]({dashboardUri})",
CompletionState.Completed,
context.CancellationToken).ConfigureAwait(false);
src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs
Show resolved
Hide resolved
|
/test-deployment |
|
/deployment-test |
|
🚀 Deployment tests starting on PR #14377... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
|
❌ Deployment E2E Tests failed Summary: 12 passed, 2 failed, 0 cancelled Passed Tests
Failed Tests
🎬 Terminal Recordings
|
|
@mitchdenny - at the end of DeployStarterTemplateToAks - https://asciinema.org/a/Yqeqmp8kUvpjGWFc It is just hung at this point:
|
Description
PrintDashboardUrlAsyncin bothAzureContainerAppEnvironmentResourceandAzureAppServiceEnvironmentResourcereports the dashboard URL viaReportingStep.CompleteAsync()but doesn't add it to thePipelineSummary. After a successful deployment, the summary table now includes the dashboard link:context.Summary.Add("📊 Dashboard", dashboardUrl)added toPrintDashboardUrlAsyncDashboardUriReference.GetValueAsync()returnsstring?Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms/usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicep9jAnMN/env-acr.module.bicep --stdout(dns block)/usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-biceplxnsky/teststorage.module.bicep --stdout(dns block)/usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicepND9qLh/env.module.bicep --stdout(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.