Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

Description

PrintDashboardUrlAsync in both AzureContainerAppEnvironmentResource and AzureAppServiceEnvironmentResource reports the dashboard URL via ReportingStep.CompleteAsync() but doesn't add it to the PipelineSummary. After a successful deployment, the summary table now includes the dashboard link:

  ☁️ Target: Azure
  📦 Resource Group: rg-myapp-dev
  🔑 Subscription: a1b2c3d4-...
  🌐 Location: eastus2
  webfrontend: https://webfrontend.happyrock-abc123...
  📊 Dashboard: https://aspire-dashboard.ext.happyrock-abc123...   ← new
  • ACA: context.Summary.Add("📊 Dashboard", dashboardUrl) added to PrintDashboardUrlAsync
  • App Service: Same, with a null guard since DashboardUriReference.GetValueAsync() returns string?

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • aka.ms
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicep9jAnMN/env-acr.module.bicep --stdout (dns block)
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-biceplxnsky/teststorage.module.bicep --stdout (dns block)
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicepND9qLh/env.module.bicep --stdout (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Add the ACA and AppService dashboard summary links to the summary just like in #14367


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ACA and AppService dashboard summary links Add ACA and AppService dashboard URLs to pipeline summary Feb 6, 2026
Copilot AI requested a review from eerhardt February 6, 2026 20:32
Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 6, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • aka.ms
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicep5DlQxt/env-acr.module.bicep --stdout (dns block)
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicep6uywXw/teststorage.module.bicep --stdout (dns block)
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicepBeBCAc/env.module.bicep --stdout (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from eerhardt February 6, 2026 20:37
@eerhardt eerhardt marked this pull request as ready for review February 6, 2026 20:38
Copilot AI review requested due to automatic review settings February 6, 2026 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14377

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14377"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Aspire dashboard URLs to the pipeline deployment summary for Azure Container Apps (ACA) and Azure App Service environments, so the dashboard link appears in the post-deploy PipelineSummary (similar to the Docker Compose pattern introduced in #14367).

Changes:

  • Add context.Summary.Add("📊 Dashboard", ...) to ACA environment print-summary step.
  • Add context.Summary.Add("📊 Dashboard", ...) to App Service environment print-summary step with a null/empty guard.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs Adds the dashboard URL to PipelineSummary during the print-summary step.
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs Adds the constructed ACA dashboard URL to PipelineSummary during the print-summary step.
Comments suppressed due to low confidence (1)

src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs:156

  • If dashboardUri is null/empty/whitespace, this will still report Dashboard available at []() which is misleading. Consider returning early (or emitting a different completion message) when the dashboard URL isn’t available so the step output stays accurate.
        await context.ReportingStep.CompleteAsync(
            $"Dashboard available at [{dashboardUri}]({dashboardUri})",
            CompletionState.Completed,
            context.CancellationToken).ConfigureAwait(false);

Copilot AI changed the title Add ACA and AppService dashboard URLs to pipeline summary Add dashboard URL to pipeline summary for ACA and App Service deployments Feb 6, 2026
@eerhardt eerhardt enabled auto-merge (squash) February 6, 2026 23:12
@davidfowl
Copy link
Member

/test-deployment

@davidfowl
Copy link
Member

/deployment-test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

🚀 Deployment tests starting on PR #14377...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing February 7, 2026 00:23 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Deployment E2E Tests failed

Summary: 12 passed, 2 failed, 0 cancelled

View workflow run

Passed Tests

  • ✅ AzureEventHubsDeploymentTests
  • ✅ AppServicePythonDeploymentTests
  • ✅ AzureAppConfigDeploymentTests
  • ✅ AzureContainerRegistryDeploymentTests
  • ✅ AuthenticationTests
  • ✅ PythonFastApiDeploymentTests
  • ✅ AzureLogAnalyticsDeploymentTests
  • ✅ AzureKeyVaultDeploymentTests
  • ✅ AzureServiceBusDeploymentTests
  • ✅ AcaStarterDeploymentTests
  • ✅ AppServiceReactDeploymentTests
  • ✅ AzureStorageDeploymentTests

Failed Tests

  • ❌ AksStarterDeploymentTests
  • ❌ AksStarterWithRedisDeploymentTests

🎬 Terminal Recordings

Test Recording
DeployAzureAppConfigResource ▶️ View Recording
DeployAzureContainerRegistryResource ▶️ View Recording
DeployAzureEventHubsResource ▶️ View Recording
DeployAzureKeyVaultResource ▶️ View Recording
DeployAzureLogAnalyticsResource ▶️ View Recording
DeployAzureServiceBusResource ▶️ View Recording
DeployAzureStorageResource ▶️ View Recording
DeployPythonFastApiTemplateToAzureAppService ▶️ View Recording
DeployPythonFastApiTemplateToAzureContainerApps ▶️ View Recording
DeployReactTemplateToAzureAppService ▶️ View Recording
DeployStarterTemplateToAks ▶️ View Recording
DeployStarterTemplateToAzureContainerApps ▶️ View Recording
DeployStarterTemplateWithRedisToAks ▶️ View Recording

@eerhardt eerhardt merged commit 159854b into main Feb 7, 2026
360 of 363 checks passed
@eerhardt eerhardt deleted the copilot/add-aca-appservice-dashboard-links branch February 7, 2026 01:28
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Feb 7, 2026
@eerhardt
Copy link
Member

eerhardt commented Feb 7, 2026

@mitchdenny - at the end of DeployStarterTemplateToAks - https://asciinema.org/a/Yqeqmp8kUvpjGWFc

It is just hung at this point:

[14 OK] $ cd AksStarter.AppHost
[15 OK] $ az acr login --name acrs217705155021 > Unable to get AAD authorization tokens with message: AADSTS700024: Client assertion is not within its valid time range. Current time: 2026-02-07T00:36:58.9834476Z, assertion valid from 2026-02-07T00:26:52.0000000Z, expiry time of assertion 2026-02-07T00:31:52.0000000Z. Review the documentation at https://learn.microsoft.com/entra/identity-platform/certificate-credentials . Trace ID: c71d926a-523a-4252-a7af-34637d954300 Correlation ID: 7bb171b1-2f74-45cc-bd9d-3573ce9309db Timestamp: 2026-02-07 00:36:58Z
Unable to get admin user credentials with message: Admin user is disabled.
Username:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants