Stop running AppHost before adding packages by mitchdenny · Pull Request #14573 · dotnet/aspire

mitchdenny · 2026-02-19T07:24:55Z

Summary

When running aspire add while an AppHost is running in detached mode, the project file is locked by the build server, causing dotnet add package to fail. The add command now stops any running AppHost instance before attempting to add the package.

Changes

Added a call to project.CheckAndHandleRunningInstanceAsync() in AddCommand before invoking AddPackageAsync()
Uses the same running instance detection pattern already used by the RunCommand
The CheckAndHandleRunningInstanceAsync method displays user-visible messages about stopping the instance (via RunningInstanceManager)

Addresses part of #14238

When running 'aspire add' while an AppHost is running in detached mode, the project file is locked by the build server, causing 'dotnet add package' to fail. The add command now stops any running AppHost instance before attempting to add the package, using the same running instance detection pattern used by the run command. Fixes part of #14238 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-02-19T07:25:05Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14573

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14573"

Copilot

Pull request overview

This PR updates the aspire add workflow to avoid dotnet add package failing when the AppHost project is locked by a detached running AppHost instance, by proactively stopping any detected running instance before modifying the project.

Changes:

Calls project.CheckAndHandleRunningInstanceAsync(...) in AddCommand before invoking AddPackageAsync().
Adds inline comments explaining why a running AppHost can block package installation.

src/Aspire.Cli/Commands/AddCommand.cs

github-actions · 2026-02-19T07:49:10Z

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit bff6ea5:

Test	Recording
AddPackageInteractiveWhileAppHostRunningDetached	▶️ View Recording
AddPackageWhileAppHostRunningDetached	▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect	▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig	▶️ View Recording
Banner_DisplayedOnFirstRun	▶️ View Recording
Banner_DisplayedWithExplicitFlag	▶️ View Recording
CreateAndDeployToDockerCompose	▶️ View Recording
CreateAndDeployToDockerComposeInteractive	▶️ View Recording
CreateAndPublishToKubernetes	▶️ View Recording
CreateAndRunAspireStarterProject	▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle	▶️ View Recording
CreateAndRunJsReactProject	▶️ View Recording
CreateAndRunPythonReactProject	▶️ View Recording
CreateEmptyAppHostProject	▶️ View Recording
CreateStartAndStopAspireProject	▶️ View Recording
CreateStartWaitAndStopAspireProject	▶️ View Recording
CreateTypeScriptAppHostWithViteApp	▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig	▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted	▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	▶️ View Recording
LogsCommandShowsResourceLogs	▶️ View Recording
PsCommandListsRunningAppHost	▶️ View Recording
ResourcesCommandShowsRunningResources	▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels	▶️ View Recording

_{📹 Recordings uploaded automatically from CI run #22209757033}

Validates that 'aspire add' succeeds when an AppHost is running in detached mode. The add command should automatically stop the running AppHost to release file locks before modifying the project. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The aspire add --non-interactive flag doesn't suppress the version selection prompt. Updated the test to wait for and accept the default version before continuing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Gate CheckAndHandleRunningInstanceAsync behind KnownFeatures.RunningInstanceDetectionEnabled feature flag, matching RunCommand behavior - Check RunningInstanceResult.StopFailed return value and fail early with a clear error message instead of proceeding - Add E2E test for interactive aspire add flow (no integration argument) while AppHost is running in detached mode Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JamesNK · 2026-02-20T01:12:00Z

src/Aspire.Cli/Commands/AddCommand.cs

+            // which prevents 'dotnet add package' from modifying the project.
+            if (_features.IsFeatureEnabled(KnownFeatures.RunningInstanceDetectionEnabled, defaultValue: true))
+            {
+                var runningInstanceResult = await project.CheckAndHandleRunningInstanceAsync(


Isn't FindAndStopRunningInstanceAsync a better name? Check and handle are pretty generic descriptors.

JamesNK · 2026-02-20T01:18:25Z

tests/Aspire.Cli.EndToEnd.Tests/StartStopTests.cs

+            .Find($"Enter the project name ({workspace.WorkspaceRoot.Name}): ");
+
+        var waitingForOutputPathPrompt = new CellPatternSearcher()
+            .Find("Enter the output path:");


The hardcoded text in these E2E tests worries me. When we change text (which will be often) tests will fail, and the E2E tests don't give friendly error messages.

They don't say something actionable like "Enter the output path: was not found", but have a message like "Timeout after 30 seconds".

JamesNK · 2026-02-20T01:21:07Z

src/Aspire.Cli/Commands/AddCommand.cs

+                if (runningInstanceResult == RunningInstanceResult.StopFailed)
+                {
+                    InteractionService.DisplayError(AddCommandStrings.UnableToStopRunningInstances);
+                    return ExitCodeConstants.FailedToAddPackage;
+                }


How come this is only written when there is a failure to stop but not success to stop? Shouldn't the previous method either log about both or about none?

The aspire add command now auto-stops the running AppHost, so the subsequent aspire stop cleanup command returns exit code 7 (no running instances found). Use a generic prompt pattern that accepts both OK and ERR exit codes for the cleanup step. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The RightText() method checks for immediately-adjacent text, but the ERR prompt has intermediate text between the counter and '] $'. Instead, wait for the known aspire stop output messages which correctly handles both 'no running instances' and 'stopped successfully' outcomes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ceAsync Address PR feedback from JamesNK: the method name is more descriptive about what the method actually does — finds running instances and stops them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

joperezr · 2026-02-20T20:36:07Z

src/Aspire.Cli/Commands/AddCommand.cs

+            // which prevents 'dotnet add package' from modifying the project.
+            if (_features.IsFeatureEnabled(KnownFeatures.RunningInstanceDetectionEnabled, defaultValue: true))
+            {
+                var runningInstanceResult = await project.FindAndStopRunningInstanceAsync(


Should this prompt to the user with something like: "A running AppHost was detected. Would you like to stop it to be able to add the integration?" Or something along those lines? I understand this is behind a feature flag, but I just feel like it might be worth it to prevent folks from shooting themselves in the foot (especially given things like logs and telemetry are likely lost after stopping.)

I realize this is the same thing that happens if a user calls aspire run again on a detached project, so perhaps that's something we can consider as a follow up for potential UX issues. Also, with a subsequent aspire run I guess the current behavior might even be expected to some degree, while perhaps aspire add is not as intuitive since folks would like not assume we are keeping a handle on the project.

joperezr · 2026-02-20T20:41:17Z

src/Aspire.Cli/Commands/AddCommand.cs

+                    ExecutionContext.HomeDirectory,
+                    cancellationToken);
+
+                if (runningInstanceResult == RunningInstanceResult.StopFailed)


I noticed that in the RunCommand we actually still go ahead with the command even if stopping fails, unlike here. Assuming that is intentional as we know this will break otherwise.

joperezr

Some minor feedback from me, but nothing really blocking.

Copilot AI review requested due to automatic review settings February 19, 2026 07:24

Copilot started reviewing on behalf of mitchdenny February 19, 2026 07:25 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

src/Aspire.Cli/Commands/AddCommand.cs Outdated Show resolved Hide resolved

src/Aspire.Cli/Commands/AddCommand.cs Outdated Show resolved Hide resolved

mitchdenny linked an issue Feb 19, 2026 that may be closed by this pull request

CLI commands suggestions #14238

Open

Mitch Denny and others added 2 commits February 19, 2026 19:28

Fix E2E test to handle version selection prompt

b0a478e

The aspire add --non-interactive flag doesn't suppress the version selection prompt. Updated the test to wait for and accept the default version before continuing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions bot mentioned this pull request Feb 19, 2026

[13.2-burndown] Daily Burndown Report - February 19, 2026 📊 #14581

Closed

JamesNK reviewed Feb 20, 2026

View reviewed changes

Mitch Denny and others added 3 commits February 20, 2026 12:27

github-actions bot mentioned this pull request Feb 20, 2026

[13.2-burndown] Daily Burndown Report - February 20, 2026 📊 #14594

Closed

joperezr reviewed Feb 20, 2026

View reviewed changes

joperezr approved these changes Feb 20, 2026

View reviewed changes

github-actions bot mentioned this pull request Feb 22, 2026

[13.2-burndown] Daily Burndown Report - February 22, 2026 #14608

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Stop running AppHost before adding packages#14573

Stop running AppHost before adding packages#14573
mitchdenny wants to merge 7 commits intorelease/13.2from
fix/add-command-stop-running-apphost

mitchdenny commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

JamesNK Feb 20, 2026

Uh oh!

JamesNK Feb 20, 2026

Uh oh!

JamesNK Feb 20, 2026

Uh oh!

joperezr Feb 20, 2026

Uh oh!

joperezr Feb 20, 2026 •

edited

Loading

Uh oh!

joperezr Feb 20, 2026

Uh oh!

joperezr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

mitchdenny commented Feb 19, 2026

Summary

Changes

Uh oh!

github-actions bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎬 CLI E2E Test Recordings

Uh oh!

JamesNK Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

JamesNK Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

JamesNK Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

joperezr Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

joperezr Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joperezr Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

joperezr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 19, 2026 •

edited

Loading

github-actions bot commented Feb 19, 2026 •

edited

Loading

joperezr Feb 20, 2026 •

edited

Loading