Fix call stack exceeded frontend error by ensuring dialog close before nested dialog opens#14654
Merged
JamesNK merged 2 commits intodotnet:release/13.2from Feb 24, 2026
Merged
Conversation
…ings dialog (dotnet#14407) Close the Settings dialog before opening the ManageDataDialog to prevent concurrent focus traps from causing a 'Maximum call stack size exceeded' error in the browser's web-components.js. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…fix/14407-settings-dialog-focus-trap
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14654Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14654" |
mitchdenny
approved these changes
Feb 24, 2026
JamesNK
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures dialog is closed before manage telemetry dialog opens.
Fixes #14407
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: