Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14667Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14667" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports E2E test refactoring changes from PR #14369 to centralize test terminal creation and helper methods, preventing merge conflicts with the main branch.
Changes:
- Created a new shared
Hex1bTestHelpers.csfile containing centralized terminal creation,SequenceCounter, and prompt-waiting extension methods - Refactored both CLI and Deployment E2E test projects to use the centralized helpers instead of duplicated code
- Added global usings to make the shared namespace available across all test files
Reviewed changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Shared/Hex1bTestHelpers.cs | New shared helper file containing SequenceCounter, CreateTestTerminal, and extension methods for waiting on terminal prompts |
| tests/Aspire.Deployment.EndToEnd.Tests/GlobalUsings.cs | Added global using for Aspire.Tests.Shared namespace |
| tests/Aspire.Cli.EndToEnd.Tests/GlobalUsings.cs | Added global using for Aspire.Tests.Shared namespace |
| tests/Aspire.Deployment.EndToEnd.Tests/Helpers/DeploymentE2ETestHelpers.cs | Updated to delegate to shared helpers; removed duplicate extension methods |
| tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2ETestHelpers.cs | Updated to delegate to shared helpers; removed duplicate extension methods; minor comment improvements |
| tests/Aspire.Deployment.EndToEnd.Tests/Helpers/SequenceCounter.cs | Deleted (moved to shared location) |
| tests/Aspire.Cli.EndToEnd.Tests/Helpers/SequenceCounter.cs | Deleted (moved to shared location) |
| tests/Aspire.Deployment.EndToEnd.Tests/*.cs (21 test files) | Updated to use DeploymentE2ETestHelpers.CreateTestTerminal() instead of manual terminal creation |
| tests/Aspire.Cli.EndToEnd.Tests/*.cs (18 test files) | Updated to use CliE2ETestHelpers.CreateTestTerminal() instead of manual terminal creation |
| tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj | Added compile reference to shared Hex1bTestHelpers.cs |
| tests/Aspire.Cli.EndToEnd.Tests/Aspire.Cli.EndToEnd.Tests.csproj | Added compile reference to shared Hex1bTestHelpers.cs |
| .github/skills/deployment-e2e-testing/SKILL.md | Updated example to use new centralized helper method |
| .github/skills/cli-e2e-testing/SKILL.md | Updated documentation to reflect new pattern; removed recordingPath example |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22380982080 |
Member
|
/deployment-test |
Contributor
|
🚀 Deployment tests starting on PR #14667... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
mitchdenny
approved these changes
Feb 25, 2026
Contributor
|
✅ Deployment E2E Tests passed Summary: 24 passed, 0 failed, 0 cancelled Passed Tests
🎬 Terminal Recordings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport changes from #14369. Prevent ongoing merge conflicts.