Merged
Conversation
ghost
added
the
area-app-model
JamesNK
approved these changes
Feb 13, 2024
joperezr
reviewed
Feb 13, 2024
joperezr
reviewed
Feb 13, 2024
| namespace Aspire.Hosting.ApplicationModel; | ||
|
|
||
| /// <summary> | ||
| /// TODO: Doc Comments |
Member
There was a problem hiding this comment.
Don't know if you did already, but it'd be great if we also log an issue for all of these TODO's that were added. Of course just a single issue for all is sufficient.
Member
Author
There was a problem hiding this comment.
I plan on logging it once this change is merged.
joperezr
reviewed
Feb 13, 2024
joperezr
reviewed
Feb 13, 2024
| namespace Aspire.Hosting.Publishing; | ||
|
|
||
| public class ManifestPublisher(ILogger<ManifestPublisher> logger, | ||
| internal class ManifestPublisher(ILogger<ManifestPublisher> logger, |
Member
Author
There was a problem hiding this comment.
I don't think this deserves a one-off breaking change notice. I don't expect users to have used this type in their code. We could roll it in with the other breaking change notices for the appmodel.
cc @mitchdenny
joperezr
reviewed
Feb 13, 2024
Fail the build when a public member is not documented. Since there are so many violations, for the current ones that weren't straight forward, I added a TODO for someone more familiar with the API to add the comments.
eerhardt
force-pushed
the
XmlDocsWArning
branch
from
a788edc to
e6f9e82
Compare
Closed
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 14, 2024
* Enable XML doc error Fail the build when a public member is not documented. Since there are so many violations, for the current ones that weren't straight forward, I added a TODO for someone more familiar with the API to add the comments. * Add XML docs for new APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail the build when a public member is not documented.
Since there are so many violations, for the current ones that weren't straight forward, I added a TODO for someone more familiar with the API to add the comments.
Microsoft Reviewers: Open in CodeFlow