Container surrogate for UseEmulator for Azure Storage.#2132
Merged
mitchdenny merged 8 commits intomainfrom Feb 10, 2024
Merged
Conversation
davidfowl
reviewed
Feb 8, 2024
playground/AzureStorageEndToEnd/AzureStorageEndToEnd.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Feb 8, 2024
playground/AzureStorageEndToEnd/AzureStorageEndToEnd.ApiService/Program.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Feb 9, 2024
davidfowl
reviewed
Feb 10, 2024
playground/AzureStorageEndToEnd/AzureStorageEndToEnd.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Feb 10, 2024
playground/AzureStorageEndToEnd/AzureStorageEndToEnd.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Feb 10, 2024
davidfowl
reviewed
Feb 10, 2024
src/Aspire.Hosting.Azure/AzureStorageEmulatorContainerResource.cs
Outdated
Show resolved
Hide resolved
…rogram.cs Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
reviewed
Feb 10, 2024
IEvangelist
reviewed
Feb 10, 2024
|
|
||
| namespace Aspire.Hosting.Azure; | ||
|
|
||
| public class AzureStorageEmulatorResource(AzureStorageResource innerResource) : ContainerResource(innerResource.Name), IResource |
Member
There was a problem hiding this comment.
All public APIs should have triple slash comments. We should not merge any PRs without them, perhaps we can fail the build or something if they're missing? //cc @davidfowl and @mitchdenny
Contributor
There was a problem hiding this comment.
Yes, we should start to do that.
This was referenced Feb 11, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 12, 2024
* Container surrogate for UseEmulator for Azure Storage. * PR feedback. * Create a factory method of IDAB to create a builder. * Update playground/AzureStorageEndToEnd/AzureStorageEndToEnd.AppHost/Program.cs Co-authored-by: David Fowler <davidfowl@gmail.com> * Remove absolute path. * PR feedback. * Feedback. --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container surrogate for Azure Storage. The idea is that with this optional callback you can manipuate the underlying resource as if it were a container when using the emulator. This was a model proposed at the App Model offsite.
The builder in the callback on
UseEmulatoris for typeAzureStorageEmulatorContainerResourcewhich derives fromContainerResourceto activate all of those extension methods. The annotations a proxied through to the underlying resource.Here is an example of using the code to enable persistent storage: