Skip to content

Display version information in dashboard and host#2242

Merged
sebastienros merged 4 commits intomainfrom
sebros/version
Feb 22, 2024
Merged

Display version information in dashboard and host#2242
sebastienros merged 4 commits intomainfrom
sebros/version

Conversation

@sebastienros
Copy link
Copy Markdown
Contributor

@sebastienros sebastienros commented Feb 15, 2024

Fixes #2222

...
info: Aspire.Hosting.DistributedApplication[0]
      Version: 8.0.0-dev
info: Aspire.Hosting.DistributedApplication[0]
      Distributed application started. Press CTRL-C to stop.

and

2024-02-14T19:00:26.3890044 info: Aspire.Dashboard[0]
      Version: 8.0.0-dev
2024-02-14T19:00:26.3995683 info: Aspire.Dashboard[0]
      Now listening on: https://localhost:15887/

Locally it shows limited information but when published the metadata should be complete. I checked with the nuget packages that it's provided. I'll check again when it merged in the nightly feed.

Microsoft Reviewers: Open in CodeFlow

@sebastienros sebastienros requested a review from JamesNK February 15, 2024 03:06
@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 15, 2024
Copy link
Copy Markdown
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of tweaks:

  • Write Aspire version:
  • Comment about why

sebastienros and others added 3 commits February 15, 2024 09:27
Co-authored-by: James Newton-King <james@newtonking.com>
Co-authored-by: James Newton-King <james@newtonking.com>
# Conflicts:
#	src/Aspire.Hosting/DistributedApplicationLifecycle.cs
@sebastienros sebastienros enabled auto-merge (squash) February 21, 2024 23:16
@radical
Copy link
Copy Markdown
Member

radical commented Feb 22, 2024

Just wondering - would it be useful to surface these versions in the dashboard UI too?

@sebastienros sebastienros merged commit ba43547 into main Feb 22, 2024
@sebastienros sebastienros deleted the sebros/version branch February 22, 2024 22:35
@JamesNK
Copy link
Copy Markdown
Member

JamesNK commented Feb 22, 2024

It already is in the settings popup.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Aspire version number and/or git SHA to console logging

3 participants