Display version information in dashboard and host#2242
Merged
sebastienros merged 4 commits intomainfrom Feb 22, 2024
Merged
Conversation
JamesNK
approved these changes
Feb 15, 2024
Member
JamesNK
left a comment
There was a problem hiding this comment.
Looks good. Couple of tweaks:
- Write
Aspire version: - Comment about why
Co-authored-by: James Newton-King <james@newtonking.com>
Co-authored-by: James Newton-King <james@newtonking.com>
# Conflicts: # src/Aspire.Hosting/DistributedApplicationLifecycle.cs
Member
|
Just wondering - would it be useful to surface these versions in the dashboard UI too? |
Member
|
It already is in the settings popup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2222
and
Locally it shows limited information but when published the metadata should be complete. I checked with the nuget packages that it's provided. I'll check again when it merged in the nightly feed.
Microsoft Reviewers: Open in CodeFlow