Fix some issues around port forwarding:#7152
Conversation
- Make sure there aren't duplicate labels when written to settings files - Mark auto forward action for dashboard as open browser and other endpoints as silent. - Default to hybrid mode for auto port forward. We want to detect ports from the output, but we also want to tear down the portforward when the process dies. Fixes #7148 Fixes #7147
- Attempt to make the end to end more reliable by adding a delay between the file writing and logging the output urls. - Don't forward any ports that aren't described in settings.
mitchdenny
left a comment
There was a problem hiding this comment.
Looks good. Tested it and is very responsive to port changes. Would be good to avoid the pause but we'll need to wait to hear from the VSCode team.
|
One thing we might want to consider is whether the port label needs some kind of apphost prefix to make it unique per apphost. in theory someone can two two apphosts within a Codespace just fine. |
Sleep always works 😉
I was going to do that (put the apphost name in there as a suffix), but then we would need to attempt to clean up the file. It turns out the VS debugger does not gracefully exit the process so there's no change to clear the file. It could be done on the next run though. |
|
Failures unrelated to the this (cosmos db) |
|
Oh one other idea I had in general was to clean up finish modeling the dashboard cleanly as a resource. That would fix a few things:
|
|
🤔 |
Description
Make sure there aren't duplicate labels when written to settings files
Mark auto forward action for dashboard as open browser and other endpoints as silent.
Default to hybrid mode for auto port forward. We want to detect ports from the output, but we also want to tear down the portforward when the process dies.
Fixes #7147
Fixes #7148
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):