Split off "hide timestamp" setting from rest of console log state#7220
Merged
JamesNK merged 4 commits intomicrosoft:mainfrom Jan 28, 2025
Merged
Conversation
added 2 commits
January 23, 2025 13:06
…and remove timestamp
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs:315
- Ensure that all references to the renamed method
ToggleTimestampAsyncare updated accordingly.
private async Task ToggleTimestampAsync(bool hideTimestamp)
src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs:548
- Add tests to cover the new
ConsoleLogTimestampStateclass to ensure it works as expected.
public record ConsoleLogTimestampState(bool HideTimestamp);
JamesNK
reviewed
Jan 23, 2025
| await this.AfterViewModelChangedAsync(_contentLayout, waitToApplyMobileChange: false); | ||
| await SessionStorage.SetAsync(HideTimestampStorageKey, new ConsoleLogTimestampState(HideTimestamp: hideTimestamp)); | ||
| _hideTimestamp = hideTimestamp; | ||
| StateHasChanged(); |
Member
There was a problem hiding this comment.
Is this nessessary? I would have thought that it would be triggered automatically after the click event
Member
Author
JamesNK
reviewed
Jan 24, 2025
JamesNK
approved these changes
Jan 28, 2025
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This also removes it from the query string.
Fixes #7137
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):