Skip to content

Fix hide/show timestamp button and default to hidden#7294

Merged
davidfowl merged 1 commit intomainfrom
jamesnk/hide-timestamp
Jan 28, 2025
Merged

Fix hide/show timestamp button and default to hidden#7294
davidfowl merged 1 commit intomainfrom
jamesnk/hide-timestamp

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Jan 28, 2025

Description

There was a regression in #7220 that causes the menu to not update when toggling between show and hide. Fixed.

Also, changed the default timestamp state to hidden. This matches what GitHub actions does in its console output, with show timestamps defaulted to off:

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Copy Markdown
Contributor

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants