Expose ResourceNotificationService through DistributedApplication#7517
Merged
ReubenBond merged 1 commit intomainfrom Feb 10, 2025
Merged
Conversation
d8ee3b0 to
cebbf08
Compare
cebbf08 to
c2ec165
Compare
davidfowl
approved these changes
Feb 10, 2025
eerhardt
reviewed
Feb 11, 2025
Member
eerhardt
left a comment
There was a problem hiding this comment.
This is nice and clean. I like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
ResourceNotificationproperty of typeResourceNotificationServicetoDistributedApplicationand updates internal usage to consume it.Fixes #6795
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate): Update "Access resources in .NET Aspire tests" to useDistributedApplication.ResourceNotificationsdotnet/docs-aspire#2563