Skip to content

Expose ResourceNotificationService through DistributedApplication#7517

Merged
ReubenBond merged 1 commit intomainfrom
rebond/distributed-application-resourcenotifications
Feb 10, 2025
Merged

Expose ResourceNotificationService through DistributedApplication#7517
ReubenBond merged 1 commit intomainfrom
rebond/distributed-application-resourcenotifications

Conversation

@ReubenBond
Copy link
Copy Markdown
Member

@ReubenBond ReubenBond commented Feb 10, 2025

Description

Adds a ResourceNotification property of type ResourceNotificationService to DistributedApplication and updates internal usage to consume it.

Fixes #6795

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@ReubenBond ReubenBond marked this pull request as ready for review February 10, 2025 22:23
@ReubenBond ReubenBond force-pushed the rebond/distributed-application-resourcenotifications branch 2 times, most recently from d8ee3b0 to cebbf08 Compare February 10, 2025 22:37
@ReubenBond ReubenBond force-pushed the rebond/distributed-application-resourcenotifications branch from cebbf08 to c2ec165 Compare February 10, 2025 23:10
@ReubenBond ReubenBond requested a review from davidfowl February 10, 2025 23:31
@ReubenBond ReubenBond merged commit 3eebc37 into main Feb 10, 2025
@ReubenBond ReubenBond deleted the rebond/distributed-application-resourcenotifications branch February 10, 2025 23:44
Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice and clean. I like it.

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose ResourceNotificationService directly on DistributedApplicationTestingBuilder

3 participants