3.0 SDK copies Properties/launchSettings.json to output directory

[dasMulli]

When a project referencing the Razor SDK (directly or through web/* SDKs), and contains a Properties\launchSettings.json file, it will be copied to the build output but not the publish output.

The SDK explicitly forbids copying assets in $(AppDesignerFolder) to the publish directory.

In the 3.0 wave, the behaviour of dotnet build was changed to be more like dotnet publish. The web SDKs should follow the same philosophy and not copy development assets needlessly to avoid users copying them to production (which could contain env vars with connection strings or similar).

To Reproduce

Steps to reproduce the behavior:

1. Use .NET Core SDK 3.0.100
2. dotnet new razor
3. dotnet build -c Release
4. See that the output contains bin\Release\netcoreapp3.0\Properties\launchSettings.json

Expected behavior

Assets in Properties folder not copied to the build output (Behaviour before 3.0.* SDKs).

Additional context

The Razor SDK contains

    <!-- Set CopyToPublishDirectory to Never for items under AppDesignerFolder ("Properties", by default) to avoid publishing launchSettings.json -->
    <Content Update="$(AppDesignerFolder)\**" CopyToPublishDirectory="Never" Condition="'$(AppDesignerFolder)' != ''"/>

in Sdk.Razor.StaticAssets.ProjectSystem.props but I cannot find this file on GitHub..

Adding CopyToOutputDirectory="Never" would address this issue.

[mkArtakMSFT]

Thanks for contacting us, @dasMulli.
@pranavkm can you please look into this? Thanks!

[javiercn]

See dotnet/core#3560 too

[dasMulli]

Looks like this introduced again in dotnet/razor#928 after being fixed in dotnet/razor#820 (which broke editing the file in VS since it was no longer a content item.)

There was a discussion if there was a dotnet run scenario that needed it.. dotnet run however only looks in the project directory - https://github.com/dotnet/cli/blob/bd5a41c369859f07652b6eb2ec1f63d3366e2575/src/dotnet/commands/dotnet-run/RunCommand.cs

[dasMulli]

Btw looks like i didn't find the targets i was looking for because of #14846. Luckily the static assets target is in a Sdk dir so i could find at least that one through GitHub search

[pranavkm]

@vijayrkn what are your thoughts on this? While this sounds like a good idea to me in principle, this isn't a regression compared to the 2.x behavior. It would be much more reasonable to make a breaking change like this as part of the 5.x release. We don't want to risk inadvertently breaking expectations in a minor release.