Skip to content

Update SDK to preview 7 #12557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update SDK to preview 7 #12557

wants to merge 3 commits into from

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jul 25, 2019

@JunTaoLuo JunTaoLuo requested a review from a team as a code owner July 25, 2019 03:30
dougbu
dougbu approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds :shipit:

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jul 25, 2019

It builds! But tests fail and it's related to the SDK update, I'll address it tomorrow.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 25, 2019
@dougbu
Copy link
Contributor

dougbu commented Jul 26, 2019

@JunTaoLuo the following blocks of workarounds should be removed either in this PR or as a follow-up:

@dougbu
Copy link
Contributor

dougbu commented Jul 28, 2019

This isn't building. Any chance we could get it in before noon tomorrow?

@JunTaoLuo JunTaoLuo mentioned this pull request Jul 29, 2019
Merged
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jul 29, 2019 •
edited
Loading

I fixed a behaviour change w.r.t how we filter assemblies we put into the reference package.

As for the failing templating tests, they are caused by a behaviour change in dotnet/templating#1929. In this PR, I've taken the approach of disabling the tests. The rationale is that we should ask the templating team for details on how we should be using it.

As an alternative, I did find a way to get tests uninstallation to work: #12682. Assuming both passes, pick whichever approach you prefer.

@dougbu
Copy link
Contributor

dougbu commented Jul 29, 2019

Went with #12682

@dougbu dougbu closed this Jul 29, 2019
@dougbu dougbu deleted the johluo/p7-sdk branch July 29, 2019 17:07
@JunTaoLuo JunTaoLuo mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JunTaoLuo @dougbu @Pilchie