[Blazor] Fix publish with different combinations of SWA base paths #28539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
approved these changes
Dec 9, 2020
Contributor
|
FYI @captainsafia |
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
requested review from
a team and
SteveSandersonMS
as code owners
src/Components/WebAssembly/testassets/HostedInAspNet.Server/Startup.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/testassets/HostedInAspNet.Server/Startup.cs
Outdated
Show resolved
Hide resolved
…artup.cs Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
src/Components/WebAssembly/testassets/HostedInAspNet.Server/Startup.cs
Outdated
Show resolved
Hide resolved
…artup.cs Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
leecow
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#28017
In 5.0.1 we fixed a publish scenario where Blazor webassembly wasn't respecting the
StaticWebAssetBasePathdefined for the project. Unfortunately the logic for handling the path composition was not robust enough and while it fixed the publish output layout, it introduced an integration issue later on at runtime.The current fix makes the handling of the path more tolerant to initial and final slashes and includes a new end to end test that validates this scenario.
Customer Impact
Customers can't host blazor applications outside the root path
(/)Regression?
Yes. Worked in 3.2
Risk
Low.
We've included additional tests and E2E automation to verify this case.
Validation