-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Quic transport is no longer experimental in .NET 6 #30559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
|
Review notes: IMultiplexedConnectionListenerFactory:
IMultiplexedConnectionListener:
MultiplexedConnectionContext:
QuicTransportFactory:
WebHostBuilderMsQuicExtensions:
QuicTransportOptions:
Will remove experimental now and make changes through previews. Re-review later in .NET 6. |
|
The IFeatureCollection arguments are intended for future extensibility. Since TLS becomes a transport concern with QUIC using it for certs sounds like a viable option. Why does ConnectAsync need to return a nullable? |
@jkotalik added that feedback. Is it to make ConnectAsync return consistent with AcceptAsync? |
|
@dougbu The CI build is failing with this message:
What changes do I need to make to pass CI build? |
It's mostly not you @JamesNK (and this likely applies to every PR that targets 'main' and not-yet-verified):
|
|
Ok! No urgency to get this PR in. |
Yeah that was the idea behind it. Though maybe throwing for either if they fail to connect or accept makes more sense? |
5a510b8 to
13619ee
Compare
|
@dougbu @JunTaoLuo @wtgodbe Good to merge from a build POV? |
wtgodbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM build-wise
|
Side question: Why do the Baseline files appear in the final commit❔ They should have been updated as part of a merge from release/5.0. |
Quic transport is no longer experimental in .NET 6
This PR is a YOLO find and replace to remove
Experimentalfrom the Quic transport project and namespaces. I'd apprietate guidance on any ritutuals that are required when removing and adding packages from aspnetcore.Two things:
System.Net.Experimental.MsQuic.Microsoft.AspNetCore.Server.Kestrel.Transport.MsQuic(note:Quic->MsQuic). That's consistent with runtime's name. And in the future the Quic implementation might change to be written in managed code so we should be more specific.PR
Experimentalfrom Quic transport projectExperimentalfrom multiplex connection abstractions typesAPIs promoted from experimental status need API review.