Skip to content

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented May 21, 2021

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 21, 2021
@dougbu dougbu requested a review from a team May 21, 2021 23:31
@dougbu
Copy link
Contributor Author

dougbu commented May 21, 2021

Please review soon-ish. No need to wait for the CI because the change is independent of everything in our builds.

@dougbu dougbu merged commit 580d671 into main May 22, 2021
@dougbu dougbu deleted the dougbu/fix.backport branch May 22, 2021 00:41
@ghost ghost added this to the 6.0-preview6 milestone May 22, 2021
@dougbu
Copy link
Contributor Author

dougbu commented May 22, 2021

/fyi CI build had completed when I pushed my change into 'main'. Ignored the RazorSourceGenerator errors because they're a general issue at the moment.

dougbu added a commit that referenced this pull request May 22, 2021
- #32927 was incomplete
- dotnet/runtime version of index.js is also incorrect
@wtgodbe
Copy link
Member

wtgodbe commented May 24, 2021

Thanks - sorry for not getting to this on Thursday

dougbu added a commit that referenced this pull request May 24, 2021
- #32927 was incomplete
- dotnet/runtime version of index.js is also incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants