Skip to content

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Jun 1, 2021

  • Expose all references when not restoring
    • use empty $(MSBuildRestoreSessionId) to determine when contributing to dependency graph
  • Remove extra direct references
    • should now be part of the dependency graph automatically
  • Avoid errors about non-shared Fx references
    • not a problem unless executing restore target
  • Special case source builds

- backport of 0b0bed3 (#32718)

* Expose all references when not restoring
  - use empty `$(MSBuildRestoreSessionId)` to determine when contributing to dependency graph
* Remove extra direct references
  - should now be part of the dependency graph automatically
* Avoid errors about non-shared Fx references
  - not a problem unless executing `restore` target
* Special case source builds
@dougbu dougbu force-pushed the dougbu/more.conditional.conditions/5.0 branch from 0089db4 to c563a03 Compare June 1, 2021 21:37
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Jun 1, 2021
@dougbu dougbu added this to the 5.0.8 milestone Jun 1, 2021
@dougbu dougbu requested a review from a team June 1, 2021 21:39
- lost part of what was added to this project
@dougbu dougbu added the blocked The work on this issue is blocked due to some dependency label Jun 1, 2021
@dougbu
Copy link
Contributor Author

dougbu commented Jun 1, 2021

Marked as blocked because this one needs some manual verification

@dougbu
Copy link
Contributor Author

dougbu commented Jun 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu dougbu merged commit 57d5a46 into release/5.0 Jun 4, 2021
@dougbu dougbu deleted the dougbu/more.conditional.conditions/5.0 branch June 4, 2021 05:39
@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants