Automatically UseDeveloperExceptionPage in WebApplication#34616
Merged
Automatically UseDeveloperExceptionPage in WebApplication#34616
Conversation
davidfowl
reviewed
Jul 22, 2021
pranavkm
approved these changes
Jul 22, 2021
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Changes look fine. Just making sure we sort out the moral conundrum.
halter73
commented
Jul 22, 2021
| #if (IndividualLocalAuth) | ||
| using Company.WebApplication1.Data; | ||
| #endif | ||
| #if (OrganizationalAuth || IndividualB2CAuth || IndividualLocalAuth || MultiOrgAuth || GenerateGraph) |
Member
Author
There was a problem hiding this comment.
This prevents the first line in Program.cs from being an empty newline:
I don't like how this needs to be kept in sync with the reset of the using #if's, but I don't see a better way.
halter73
commented
Jul 22, 2021
ghost
added this to the
amcasey
added
area-minimal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34548
The corresponding spa-templates changes are at dotnet/spa-templates#5