Backport 37009: Make title prerendering not interfere with svg titles #37019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
added
the
Servicing-consider
|
Hi @SteveSandersonMS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Member
Author
|
cc @mkArtakMSFT for submission to tactics process |
SteveSandersonMS
changed the title
Contributor
|
@SteveSandersonMS can you retarget this to 6.0-ga? |
mkArtakMSFT
added
Servicing-approved
Contributor
|
This is approved for 6.0-GA!. |
SteveSandersonMS
force-pushed
the
stevesa/backport-37009
branch
from
d50840c to
219339c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #37009 to RC2
Description
Developers using
<title>elements inside SVG found that it conflicted with logic in the newPageTitlecomponent.Customer Impact
As reported in #36380:
In effect you couldn't use tooltips inside
<svg>reliably any more.Regression?
PageTitleis a new feature in 6.0, so not a regression.Risk
Localised to a fairly small component, and tested.
The product change is a one-liner: https://github.com/dotnet/aspnetcore/pull/37019/files#diff-4f9bf730b3cec6b2ddbea74c5d13941b3224f3c5c2f1169bf0070f4bb8f03902R9. The rest of the PR diff is tests and build artifacts.
Verification
Packaging changes reviewed?
Addresses #36380