Skip to content

Backport 37009: Make title prerendering not interfere with svg titles #37019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Backport 37009: Make title prerendering not interfere with svg titles #37019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be6a985
Make title prerendering not interfere with svg titles. Fixes #36380.
SteveSandersonMS Sep 27, 2021
219339c
Update .js files
SteveSandersonMS Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/Web.JS/dist/Release/blazor.server.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Components/Web.JS/dist/Release/blazor.webview.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src/Components/Web.JS/src/PageTitle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ export const PageTitle = {
};

function getAndRemoveExistingTitle(): string | null {
const titleElements = document.getElementsByTagName('title');
// Other <title> elements may exist outside <head> (e.g., inside <svg> elements) but they aren't page titles
const titleElements = document.head ? document.head.getElementsByTagName('title') : [];

if (titleElements.length === 0) {
return null;
Expand Down
4 changes: 4 additions & 0 deletions src/Components/test/E2ETest/ServerExecutionTests/HeadModificationPrerenderingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ public void CanModifyHeadDuringAndAfterPrerendering()
Browser.Equal("Title 1", () => Browser.Title);
Browser.Exists(By.Id("meta-description"));

// Check that unrelated <title> elements were left alone
Browser.Equal("This element is used to test that PageTitle prerendering doesn't interfere with non-head title elements.",
() => Browser.Exists(By.CssSelector("#svg-for-title-prerendering-test title")).Text);

var titleText1 = Browser.FindElement(By.Id("title-text-1"));
titleText1.Clear();
titleText1.SendKeys("Updated title 1\n");
Expand Down
6 changes: 6 additions & 0 deletions src/Components/test/testassets/TestServer/Pages/DeferredComponentContentLayout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,11 @@
});
}
</script>

<svg id="svg-for-title-prerendering-test" viewBox="0 0 20 10" xmlns="http://www.w3.org/2000/svg" style="width: 1px; height: 1px;">
<rect x="11" y="1" width="8" height="8">
<title>This element is used to test that PageTitle prerendering doesn't interfere with non-head title elements.</title>
</rect>
</svg>
</body>
</html>