-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add WebApi-CSharp Template Toggle Description (#37367) #38062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @captainsafia. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Do we need to localize this text? |
|
@captainsafia, I responded offline with a link to the generated files. Also, in a more general sense, the templates should be updated to use the new localization mechanism provided by the core template engine going forward. This would allow them to have their metadata localized within "dotnet new" and better streamline localization within Visual Studio. @vlada-shubina and @DavidKarlas should be able to give some guidance on this. |
|
Hi @captainsafia, Starting .NET 7, we have an MSBuild task to ease this process. This should be the way going forward. But since this PR is about .NET 6, I won't give details here. Let me know if you need to apply this to main branch and I can help you further. Starting .NET 6, we have Template Localizer tool to help with this. You should:
You can install Template Localizer tool using: Run it on the root template directory using: |
Thanks! I've updated the localizations in the templates and created #38102 to track updating our infra. |
…38062) * Add WebApi-CSharp Template Toggle Description (dotnet#37367) Partial fix for dotnet#37202 * Update localizations for WebApi-CSharp template Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
* Add WebApi-CSharp Template Toggle Description (#37367) (#38062) * Add WebApi-CSharp Template Toggle Description (#37367) Partial fix for #37202 * Update localizations for WebApi-CSharp template Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Fix typo in localization file Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
Description
This PR adds a clearer description to the "Enable OpenAPI" open in Web API templates.
Customer Impact
This change does not introduce any functional changes but makes it easier for customers to understand what happens when they check/uncheck the "Enable OpenAPI" item in the VS new project experience.
Regression?
Risk
This change adds more documentation and does not introduce functional changes to the UI.
Verification
Packaging changes reviewed?
Closes #37864