!nits! Slight Testing cleanup #40564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use more modern C# syntax - remove extra `AssemblyTestLog.Create(...)` overload - was just used in tests and other overload already more direct (and worth testing) - remove useless `ILoggedTest` interface - add solution filter and startvs.cmd file - make `LoggedTestBase` an `abstract` class - remove unused `using`s - shorten long Lines - also clean 30_api_proposal.md line endings
|
Mostly stuff I noticed while doing #40411 and not worth mixing into that work |
Pilchie
added
the
area-infrastructure
wtgodbe
approved these changes
Mar 8, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use more modern C# syntax
remove extra
AssemblyTestLog.Create(...)overloadremove useless
ILoggedTestinterfaceadd solution filter and startvs.cmd file
make
LoggedTestBaseanabstractclassremove unused
usingsshorten long Lines
also clean 30_api_proposal.md line endings