Skip to content

HTTP/3: Support QUIC idle timeout more cleanly #43037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2022
Merged

HTTP/3: Support QUIC idle timeout more cleanly #43037

merged 5 commits into from
Aug 13, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 1, 2022 •
edited
Loading

  • An HTTP/3 connection that ends because of an idle timeout logs a number of messy exception details. Look for idle exceptions and make logs cleaner.
  • Delay aborting connection with critical stream closed. Avoids race between connection and stream closing.

@ghost ghost added the area-runtime label Aug 1, 2022
@JamesNK JamesNK force-pushed the jamesnk/http3-connectionidle branch from 6dc5861 to dd7f37a Compare August 11, 2022 13:35
@JamesNK JamesNK marked this pull request as ready for review August 11, 2022 13:37
@Tratcher
Copy link
Member

Tratcher commented Aug 12, 2022 •
edited
Loading

I'm actually removing the quic idle timeout as part of #34955. Kestrel will manage the connection idle lifetime. I should have a PR ready today.

@JamesNK
Copy link
Member Author

JamesNK commented Aug 13, 2022 •
edited
Loading

These changes will still be useful for aborts and avoiding the race between closing control streams and the connection.

@JamesNK JamesNK merged commit 6887c94 into main Aug 13, 2022
@JamesNK JamesNK deleted the jamesnk/http3-connectionidle branch August 13, 2022 13:35
@ghost ghost added this to the 7.0-rc1 milestone Aug 13, 2022
@adityamandaleeka adityamandaleeka mentioned this pull request Aug 16, 2022
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

7.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesNK @Tratcher @amcasey