Skip to content

Fix missing using in Http3TimeoutTests #43311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix missing using in Http3TimeoutTests #43311

merged 1 commit into from
Aug 16, 2022

Conversation

@adityamandaleeka
Copy link
Member

@adityamandaleeka adityamandaleeka commented Aug 16, 2022 •
edited
Loading

The build is broken after this PR went in: #43250

@BrennanConroy PTAL

@ghost ghost added the area-runtime label Aug 16, 2022
@adityamandaleeka
Copy link
Member Author

@dotnet/aspnet-build I assume this will be needed in the 7.0/RC1 branches as well.

@halter73
Copy link
Member

halter73 commented Aug 16, 2022 •
edited
Loading

Use my PR instead lol! #43302

It was approved and green this morning. I changed some comments before 1pm and helix couldn't upload artifacts for the next 4 hours.

@dougbu
Copy link
Contributor

dougbu commented Aug 16, 2022

Anything missing in release/7.0-rc1 or release/7.0 (for RC2) will need to be backported (using the bot)

@adityamandaleeka
Copy link
Member Author

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/2865086295

@github-actions github-actions bot mentioned this pull request Aug 16, 2022
Merged
10 tasks
@adityamandaleeka adityamandaleeka merged commit a4906cd into dotnet:main Aug 16, 2022
@ghost ghost added this to the 7.0-rc1 milestone Aug 16, 2022
@adityamandaleeka
Copy link
Member Author

Merged on red; the upload failures plaguing this and many other PRs are unrelated, and I didn't want everything to fail with this build issue when those PRs are retried.

@dougbu
Copy link
Contributor

dougbu commented Aug 16, 2022

I'm confused. #43250 was green when it merged. Did something go in after CI validation in #43250 completed that conflicted❔ If not, what went wrong❔

@adityamandaleeka
Copy link
Member Author

#43037 went in before #43250 and added some code that depended on this using (which #43250 removed).

@dougbu
Copy link
Contributor

dougbu commented Aug 16, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/2870234158

@dougbu
Copy link
Contributor

dougbu commented Aug 16, 2022

Since we haven't configured anything for our build process yet (right @wtgodbe❔), also backported to release/7.0.

@github-actions github-actions bot mentioned this pull request Aug 16, 2022
Merged
11 tasks
@dougbu dougbu modified the milestones: 7.0-rc1, 8.0-alpha1 Aug 16, 2022
@wtgodbe
Copy link
Member

wtgodbe commented Aug 16, 2022

Correct

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienros sebastienros sebastienros approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

6 participants

@adityamandaleeka @halter73 @dougbu @wtgodbe @sebastienros @amcasey