Skip to content

Conversation

@Tom-V
Copy link
Contributor

@Tom-V Tom-V commented Oct 28, 2022

Improve some large XML comments

Improved readability of some XML comment

Description

Improved readability of the XML comments of IHttpRequestBodyDetectionFeature.CanHaveBody and JsonTranscodingRouteAdapter

Fixes #44773

The issue only includes the first change, but looking into the code, I saw the JsonTranscodingRouteAdapter could also include some improvements as it also contained a few lists. I also checked the other files within Http.Features, but didn't find any that needed real improvements.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 28, 2022
@ghost
Copy link

ghost commented Oct 28, 2022

Thanks for your PR, @Tom-V. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dnfadmin
Copy link

dnfadmin commented Oct 28, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Tom-V!

@adityamandaleeka adityamandaleeka merged commit 9b154d5 into dotnet:main Oct 28, 2022
@ghost ghost added this to the 8.0-preview1 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve IHttpRequestBodyDetectionFeature.CanHaveBody XML comment

4 participants