Skip to content

Conversation

@brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Dec 17, 2022

Reverts #44925

Unfortunately, after different engineers working on it and validating the update. After we merged the change our internal CI build is failing with:

Unhandled exception. System.NotSupportedException: Unsupported log file format. Latest supported version is 14, the log file has version 15.
   at Microsoft.Build.Logging.StructuredLogger.BinLogReader.Replay(Stream stream, Progress progress)

The FR teams is working on the update of MSBuild.StructuredLogger dotnet/source-indexer#109, however, look into the source code https://github.com/KirillOsenkov/MSBuildStructuredLog/blob/main/src/StructuredLogger/BinaryLogger/BinaryLogger.cs#L58 I don't believe the version 15 is supported yet and it will take longer to make it work again.

Since we usually update every Monday, will let the next Monday update check if the newer version dotnet/arcade#11995 will work.

Also, I believe we need make sure the tools used in the CI build are validated in PR validation as well

@wtgodbe
Copy link
Member

wtgodbe commented Dec 17, 2022

Also, I believe we need make sure the tools used in the CI build are validated in PR validation as well

There will always be some scenarios (e.g. publishing) that won't be validated by PR CI, but I agree that binlogs don't need to be one of them. I've been leaning towards turning binlogs on in PRs for a while, this seems like more good evidence that we should do that. Can you file an issue to re-enable binlogs in PRs & assign it to me?

@brunolins16 brunolins16 merged commit d2f7bd0 into main Dec 17, 2022
@brunolins16 brunolins16 deleted the revert-44925-dougbu/sdk.update branch December 17, 2022 05:20
@ghost ghost added this to the 8.0-preview1 milestone Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants