Skip to content

Fixed Router renders component twice #47880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surayya-MS merged 2 commits into from
Apr 26, 2023
Merged

Fixed Router renders component twice #47880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d703240
fix Router renders component twice
surayya-MS Apr 25, 2023
37e1f03
add test checking that component renders once when SetParametersAsync…
surayya-MS Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Components/Components/src/Routing/Router.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,10 @@ public async Task SetParametersAsync(ParameterView parameters)
_onNavigateCalled = true;
await RunOnNavigateAsync(NavigationManager.ToBaseRelativePath(_locationAbsolute), isNavigationIntercepted: false);
}

Refresh(isNavigationIntercepted: false);
else
{
Refresh(isNavigationIntercepted: false);
}
}

/// <inheritdoc />
Expand Down
25 changes: 25 additions & 0 deletions src/Components/Components/test/Routing/RouterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,31 @@ await _renderer.Dispatcher.InvokeAsync(() =>
Assert.Equal($"Rendering route matching {typeof(MultiSegmentRouteComponent)}", renderedFrame.TextContent);
}

[Fact]
public async Task SetParametersAsyncRefreshesOnce()
{
//Arrange
var parameters = new Dictionary<string, object>
{
{ nameof(Router.AppAssembly), typeof(RouterTest).Assembly },
{ nameof(Router.NotFound), (RenderFragment)(builder => { }) },
};

var refreshCalled = 0;
_renderer.OnUpdateDisplay = (renderBatch) =>
{
refreshCalled += 1;
return;
};

// Act
await _renderer.Dispatcher.InvokeAsync(() =>
_router.SetParametersAsync(ParameterView.FromDictionary(parameters)));

//Assert
Assert.Equal(1, refreshCalled);
}

internal class TestNavigationManager : NavigationManager
{
public TestNavigationManager() =>
Expand Down