Skip to content

Reenable HTTPs tests #52967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Reenable HTTPs tests #52967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SignalR/clients/ts/FunctionalTests/scripts/run-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function runJest(httpsUrl: string, httpUrl: string) {
return new Promise<number>((resolve, reject) => {
const logStream = fs.createWriteStream(path.resolve(LOGS_DIR, "node.functionaltests.log"));
// Use NODE_TLS_REJECT_UNAUTHORIZED to allow our test cert to be used by the Node tests (NEVER use this environment variable outside of testing)
const p = exec(`"${process.execPath}" "${jestPath}" --config "${configPath}"`, { env: { SERVER_URL: `${httpsUrl};${httpUrl}`, NODE_TLS_REJECT_UNAUTHORIZED: "false" }, timeout: 200000, maxBuffer: 10 * 1024 * 1024 },
const p = exec(`"${process.execPath}" "${jestPath}" --config "${configPath}"`, { env: { SERVER_URL: `${httpsUrl};${httpUrl}`, NODE_TLS_REJECT_UNAUTHORIZED: 0 as any }, timeout: 200000, maxBuffer: 10 * 1024 * 1024 },
(error: any, stdout, stderr) => {
console.log("Finished Node tests.");
if (error) {
Expand Down
2 changes: 1 addition & 1 deletion src/SignalR/clients/ts/FunctionalTests/ts/Common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export function eachHttpClient(action: (transport: HttpClient) => void): void {
}

// Run test in Node or Chrome, but not on macOS
export const shouldRunHttpsTests = false &&
export const shouldRunHttpsTests =
// Need to have an HTTPS URL
!!ENDPOINT_BASE_HTTPS_URL &&

Expand Down