Skip to content

[Blazor] Some of the default UI styling is not accessible in dark mode #57142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2024
Merged

[Blazor] Some of the default UI styling is not accessible in dark mode #57142

merged 4 commits into from
Aug 5, 2024

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Aug 2, 2024

Fixes #57111

  • Applies color-scheme: light only to the error UI to avoid problems with auto dark mode.
  • Puts the reconnect UI inside shadow dom to avoid styling on the page impacting styling on the reconnect UI.

@javiercn javiercn requested review from a team and wtgodbe as code owners August 2, 2024 13:55
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 2, 2024
@javiercn javiercn merged commit b41e166 into main Aug 5, 2024
@javiercn javiercn deleted the javiercn/a11y57111 branch August 5, 2024 11:59
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

9.0-rc1

Development

Successfully merging this pull request may close these issues.

[Blazor] Some of the default UI styling is not accessible in dark mode

3 participants

@javiercn @MackinnonBuck