Skip to content

Update to Microsoft.OpenApi 1.6.17 #57201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

Update to Microsoft.OpenApi 1.6.17 #57201

merged 1 commit into from
Aug 7, 2024

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Aug 6, 2024 •
edited
Loading

This PR updates the repo to use Microsoft.OpenApi 1.6.17 to incorporate:

  • Trim and native-AoT compat in the library
  • The new Annotations property for managing in-memory data associated with an OpenAPI document

Changes in the PR include:

  • Removing exemption for Microsoft.OpenApi package in native AoT/trimming tests
  • Removing ScrubbedOpenApi and ScrubbedJsonWriter in favor of IOpenApiAnnotatable.Annotations

@captainsafia captainsafia requested review from a team and wtgodbe as code owners August 6, 2024 20:41
@ghost ghost added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 6, 2024
@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Aug 6, 2024
eerhardt
eerhardt approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

eng/testing/linker/project.csproj.template
</ItemGroup>

<!-- Single warn the following assemblies, which have known warnings, so the warnings can be suppressed for now.
Remove this (and the above NoWarn IL2104) once https://github.com/microsoft/OpenAPI.NET/pull/1717 is merged. -->
Copy link
Member

@eerhardt eerhardt Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@captainsafia captainsafia merged commit c430536 into main Aug 7, 2024
@captainsafia captainsafia deleted the safia/update-ms-openapi branch August 7, 2024 00:18
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

9.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@captainsafia @eerhardt