[release/2.3] Delete SignalR ts client #60882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes dead code related to the SignalR TypeScript client and associated functional tests.
- Removed various hubs, test cases, and supporting utilities used solely for testing the TS client.
- Cleans up the codebase by eliminating unused files and scripts.
Reviewed Changes
Copilot reviewed 104 out of 104 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SignalR/clients/ts/FunctionalTests/UncreatableHub.cs | Deleted dead hub class. |
| src/SignalR/clients/ts/FunctionalTests/ts/ConnectionTests.ts | Removed connection tests for SignalR TS client. |
| src/SignalR/clients/ts/FunctionalTests/Program.cs | Deleted unused test server program. |
| src/SignalR/clients/ts/FunctionalTests/ts/WebSocketTests.ts | Removed WebSocket tests. |
| src/SignalR/clients/ts/FunctionalTests/AuthorizedHub.cs | Deleted hub with authorization. |
| src/SignalR/clients/ts/FunctionalTests/ComplexObject.cs | Removed dead complex object definition. |
| src/SignalR/clients/ts/FunctionalTests/EchoConnectionHandler.cs | Deleted the echo connection handler. |
| src/SignalR/clients/ts/FunctionalTests/ts/TestLogger.ts | Removed test logger implementation. |
| src/SignalR/clients/ts/FunctionalTests/TestHub.cs | Deleted test hub functionality. |
| src/SignalR/clients/ts/FunctionalTests/selenium/run-tests.ts | Removed Selenium test runner script. |
| src/SignalR/clients/ts/FunctionalTests/ts/Utils.ts | Deleted utility functions for the tests. |
| src/SignalR/clients/ts/FunctionalTests/ts/Common.ts | Removed common utilities used by TS tests. |
| src/SignalR/clients/ts/FunctionalTests/Startup.cs | Deleted startup configuration for SignalR tests. |
| src/SignalR/clients/ts/FunctionalTests/ts/WebDriverReporter.ts | Removed WebDriver reporter used in tests. |
| src/SignalR/clients/ts/FunctionalTests/selenium/run-ci-tests.ts | Deleted CI test-runner script. |
BrennanConroy
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dead code
Edit:
We decided many years ago to stop shipping the 1.X versions of @aspnet/signalr-protocol-msgpack and @aspnet/signalr npm packages. The newer clients should be backwards compatible with older servers (assuming you don't use features not available yet, e.g. streaming with a 1.X server).
Users should be using supported versions of @microsoft/signalr and @microsoft/signalr-protocol-msgpack.