Skip to content

Quarantine EnhancedNavigationScrollBehavesSameAsBrowserOnBackwardsForwardsAction #61191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

Quarantine EnhancedNavigationScrollBehavesSameAsBrowserOnBackwardsForwardsAction #61191

merged 2 commits into from
Apr 3, 2025

Conversation

@MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Mar 27, 2025 •
edited
Loading

This test seems to be flaky.

This PR comments out the argument combination I've observed to be problematic.
It also comments out other argument combinations that link to a GitHub issue but weren't already commented out. I assume these were meant to be disabled but were left enabled by accident.

Contributes to #60875

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner March 27, 2025 18:11
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Mar 27, 2025
This was referenced Mar 27, 2025
Closed
Open
@ilonatommy
Copy link
Member

ilonatommy commented Mar 28, 2025

[InlineData(true, true, false)] should be enabled for sure, I think it was my mistake when I was disabling specific data, I meant to do it only for useEnhancedNavigation: False. If you don't mind, I will change the code to move the comment down, instead of adding a new one.

@ilonatommy
Uncomment test case with EnhancedNavigation: true
b1cb785 
Only tests with browser navigation are prone to failing.
@ilonatommy ilonatommy enabled auto-merge (squash) April 3, 2025 06:27
@ilonatommy ilonatommy merged commit c3a578d into main Apr 3, 2025
27 checks passed
@ilonatommy ilonatommy deleted the mbuck/quarantine-EnhancedNavigationScrollBehavesSameAsBrowserOnBackwardsForwardsAction branch April 3, 2025 08:43
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewing lewing lewing approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

10.0-preview4

Development

Successfully merging this pull request may close these issues.

4 participants

@MackinnonBuck @ilonatommy @lewing