Alter database design for the Social Logins feature. #64192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serLogins for V3 schema Added Id primary key field to IdentityUserToken and IdentityUserLogin entities Updated V3 schema configuration to use Id primary keys with unique indexes instead of composite keys Made FindTokenAsync obsolete with guidance to use FindTokenByUniqueIndexAsync for V3 schema Updated UserStoreBase to use FindTokenByUniqueIndexAsync internally for token operations Modified UserStore and UserOnlyStore implementations to handle V3 schema with proper Id generation Updated SqlStoreTestBase to verify V3 schema includes Id columns Added comprehensive integration tests for UserManager with V3 schema Created UserStoreVersionThreeTest with specific V3 schema validation Updated DefaultUI sample to use V3 schema configuration All automated and manual testing passes successfully This change improves the database schema by using surrogate primary keys with unique indexes, which provides better performance and aligns with modern database design patterns. The V3 schema maintains backward compatibility while offering improved data access patterns
chris-briddock
requested review from
a team,
captainsafia and
tdykstra
as code owners
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
Pull Request Overview
This PR adds Docker containerization support for the IdentitySample.DefaultUI project and implements Identity V3 schema changes. The V3 schema introduces Id primary keys for IdentityUserLogin, IdentityUserToken, IdentityUserClaim, and IdentityRoleClaim entities (replacing composite primary keys with unique indexes), and includes comprehensive Docker setup scripts for Windows and Linux.
Key Changes:
- Added Docker infrastructure with compose, Dockerfile, and startup scripts (bash/batch) for running the sample with SQL Server
- Implemented V3 schema changes with Id primary keys and unique indexes for UserLogins and UserTokens
- Added external authentication support (Google) and email sender service to the sample
- Updated Entity Framework store implementations to support the new V3 schema with
FindTokenByUniqueIndexAsync
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| start.sh / start.cmd | Interactive menu-based scripts to manage Docker containers for SQL Server and web app |
| docker-compose.yml | Docker Compose configuration for SQL Server 2022 and ASP.NET Core web application |
| Dockerfile | Multi-stage build for the Identity sample using .NET 10 preview SDK and runtime |
| appsettings.json | Updated connection string to use Docker SQL Server and added Google auth configuration |
| Startup.cs | Configured V3 schema version, added Google authentication provider, and email sender service |
| IdentityUserLogin.cs / IdentityUserToken.cs / IdentityUserClaim.cs / IdentityRoleClaim.cs | Added Id primary key properties (changed from int to TKey for claims) |
| UserStoreBase.cs | Added FindTokenByUniqueIndexAsync method and obsoleted FindTokenAsync |
| UserStore.cs / UserOnlyStore.cs | Implemented FindTokenByUniqueIndexAsync using unique index queries and added Id generation for string keys |
| IdentityUserContext.cs | Updated V3 model configuration to use Id primary keys with unique indexes; V1/V2 now ignore Id property |
| Test files | Added comprehensive tests for V3 schema functionality with tokens and logins |
| .devcontainer/devcontainer.json | Updated to use proper customizations structure for VS Code extensions and settings |
| /// </summary> | ||
| public virtual TKey Id { get; set; } = default!; | ||
| /// <summary> | ||
| /// Gets or sets the foreign kwy for the user identifier. |
There was a problem hiding this comment.
Corrected spelling of 'kwy' to 'key'.
Suggested change
| /// Gets or sets the foreign kwy for the user identifier. | |
| /// Gets or sets the foreign key for the user identifier. |
| - ConnectionStrings__DefaultConnection=Server=sqlserver;Database=IdentitySample_V3;User Id=sa;Password=YourStrong@Passw0rd;TrustServerCertificate=True;MultipleActiveResultSets=true | ||
| # Social login credentials (set these in a .env file or here) | ||
| - Authentication__Google__ClientId=${GoogleClientId} | ||
| - Authentication__Google__ClientSecret={GoogleClientSecret} |
There was a problem hiding this comment.
Missing dollar sign ($) for environment variable interpolation. Should be ${GoogleClientSecret} to match the pattern used for GoogleClientId on line 33.
…serLogins for V3 schema Added Id primary key field to IdentityUserToken and IdentityUserLogin entities Updated V3 schema configuration to use Id primary keys with unique indexes instead of composite keys Made FindTokenAsync obsolete with guidance to use FindTokenByUniqueIndexAsync for V3 schema Updated UserStoreBase to use FindTokenByUniqueIndexAsync internally for token operations Modified UserStore and UserOnlyStore implementations to handle V3 schema with proper Id generation Updated SqlStoreTestBase to verify V3 schema includes Id columns Added comprehensive integration tests for UserManager with V3 schema Created UserStoreVersionThreeTest with specific V3 schema validation Updated DefaultUI sample to use V3 schema configuration All automated and manual testing passes successfully This change improves the database schema by using surrogate primary keys with unique indexes, which provides better performance and aligns with modern database design patterns. The V3 schema maintains backward compatibility while offering improved data access patterns
|
I'm going to close and re-open another because, on linux the Shipped and Unshpped APIs were amended, where it should just be the unshipped. However this did give me an error when only adding to the unshipped? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter database schema design for the Social Logins feature.
Summary of the changes (Less than 80 chars):
Add Id primary keys to IdentityUserTokens/Logins for V3 schema
Please see the attached report.
PR Report.md