Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 13, 2025

Remove RequiresPreviewFeatures from QuicTransportOptions properties

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Remove preview feature requirements from QuicTransportOptions properties

Description

Removes [RequiresPreviewFeatures] attribute from four properties in QuicTransportOptions:

  • MaxBidirectionalStreamCount
  • MaxUnidirectionalStreamCount
  • MaxReadBufferSize
  • MaxWriteBufferSize

These properties are already in PublicAPI.Shipped.txt and are now stable for general use.

Also removes the now-unused using System.Runtime.Versioning; directive.

Original prompt

Remove RequiresPreviewFeatures from QuicTransportOptions properties.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@dotnet-policy-service
Copy link
Contributor

Greetings human! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo!

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove RequiresPreviewFeatures from QuicTransportOptions properties Remove RequiresPreviewFeatures from QuicTransportOptions properties Nov 13, 2025
Copilot AI requested a review from JamesNK November 13, 2025 05:09
Copilot finished work on behalf of JamesNK November 13, 2025 05:09
@JamesNK JamesNK marked this pull request as ready for review November 13, 2025 05:10
Copilot AI review requested due to automatic review settings November 13, 2025 05:10
@JamesNK
Copy link
Member

JamesNK commented Nov 13, 2025

@halter73 @BrennanConroy These properties have been experimental since .NET 7. We're not doing any work here, and the properties seem stable. I think it's fine to remove the preview attribute.

Copilot finished reviewing on behalf of JamesNK November 13, 2025 05:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the [RequiresPreviewFeatures] attribute from four properties in QuicTransportOptions, marking them as stable API. These properties have already been shipped in the public API surface.

  • Removes preview feature restrictions from QUIC transport stream and buffer configuration properties
  • Removes the now-unused using System.Runtime.Versioning; directive

Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have anything else HTTP/3 related that still has [RequiresPreviewFeatures] other than IWebTransportSession? Should we remove it for that too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants