-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Remove RequiresPreviewFeatures from QuicTransportOptions properties #64340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove RequiresPreviewFeatures from QuicTransportOptions properties #64340
Conversation
|
Greetings human! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! |
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
|
@halter73 @BrennanConroy These properties have been experimental since .NET 7. We're not doing any work here, and the properties seem stable. I think it's fine to remove the preview attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the [RequiresPreviewFeatures] attribute from four properties in QuicTransportOptions, marking them as stable API. These properties have already been shipped in the public API surface.
- Removes preview feature restrictions from QUIC transport stream and buffer configuration properties
- Removes the now-unused
using System.Runtime.Versioning;directive
halter73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have anything else HTTP/3 related that still has [RequiresPreviewFeatures] other than IWebTransportSession? Should we remove it for that too?
Remove RequiresPreviewFeatures from QuicTransportOptions properties
Remove preview feature requirements from QuicTransportOptions properties
Description
Removes
[RequiresPreviewFeatures]attribute from four properties inQuicTransportOptions:MaxBidirectionalStreamCountMaxUnidirectionalStreamCountMaxReadBufferSizeMaxWriteBufferSizeThese properties are already in
PublicAPI.Shipped.txtand are now stable for general use.Also removes the now-unused
using System.Runtime.Versioning;directive.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.