[release/10.0] Fix circular reference resolution for schemas containing arrays #64720
+158
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is done by registering components before going deep into the recursion tree (where the leaves would be registered first). Fixing this revealed an issue for default values for "local" attributes. Local attributes/parameter info should not apply to componetized schemas.
…hema-id is null or empty
github-actions
bot
requested review from
a team and
captainsafia
as code owners
captainsafia
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64109 to release/10.0
/cc @captainsafia @desjoerd
Description
Refactors OpenAPI schema reference resolution to register componentized schemas before resolving their nested references.
Customer Impact
Users with models containing circular references through array properties (e.g., a type with ICollection) may get incorrect or broken OpenAPI schemas.
Regression?
Risk
The change refactors the order of operations in schema resolution without changing the fundamental logic. The fix is well-scoped to the schema reference resolution path and includes targeted test coverage for the specific scenario.
Verification
Packaging changes reviewed?