Skip to content

Add missing assembly references after dependency update to 11.0.0-alpha #64742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 31 commits into
base: darc-main-6224f5aa-e632-4669-b1f6-6ec23567b9ec
Choose a base branch
from
Draft

Add missing assembly references after dependency update to 11.0.0-alpha #64742

Copilot wants to merge 31 commits into from
+430 −20

Conversation

Copy link
Contributor

Copilot AI commented Dec 11, 2025 •
edited
Loading

Add missing assembly references after dependency update to 11.0.0-alpha

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Fix build errors after dependency update from 10.0.x to 11.0.0-alpha

Description

The update from 10.0.x to 11.0.0-alpha relocated types between assemblies, breaking transitive dependencies. This PR adds explicit <Reference> elements to 71 unique csproj files across the codebase through iterative fixes to resolve all build errors. Some projects received multiple rounds of reference additions as additional type dependencies were discovered during the build process.

References Added

The following assembly references were added to fix type resolution issues:

  • Microsoft.AspNetCore.Http - IHttpActivityFeature, HeaderDictionary
  • Microsoft.AspNetCore.Http.Abstractions - HttpContext, RequestDelegate, IApplicationBuilder, HttpMethods, BadHttpRequestException, routing features (IEndpointFeature, IRouteValuesFeature)
  • Microsoft.AspNetCore.Http.Features - IHeaderDictionary, IHttpRequestFeature, IFormFeature, IHttpAuthenticationFeature, IHttpResponseBodyFeature, IHttpWebSocketFeature, IHttpUpgradeFeature, IHttpExtendedConnectFeature, IResponseCookiesFeature, ITlsConnectionFeature, HttpsCompressionMode, WebSocketAcceptContext, IFormFile, IFormCollection, IFormFileCollection, IQueryCollection, IHttpMaxRequestBodySizeFeature
  • Microsoft.Extensions.Features - IFeatureCollection
  • Microsoft.AspNetCore.Hosting.Server.Abstractions - IServer, IHttpApplication<>, IServerAddressesFeature, IStartupConfigureServicesFilter, IStartupConfigureContainerFilter<>
  • Microsoft.AspNetCore.Hosting.Abstractions - IWebHostBuilder, WebHostBuilderContext, IWebHostEnvironment, IWebHost
  • Microsoft.AspNetCore.Routing.Abstractions - LinkGenerator, Endpoint, EndpointBuilder, IRouteConstraint, RouteValueDictionary, IRouter, RouteDirection
  • Microsoft.AspNetCore.Authentication.Abstractions - AuthenticationProperties, AuthenticateResult, AuthenticationTicket, IAuthenticationHandler, IAuthenticationSchemeProvider, AuthenticationScheme
  • Microsoft.AspNetCore.Authentication.Core - AddAuthenticationCore, AuthenticationFeature
  • Microsoft.AspNetCore.WebUtilities - WebUtilities namespace types
  • Microsoft.Net.Http.Headers - EntityTagHeaderValue, RangeItemHeaderValue, ContentRangeHeaderValue, ResponseHeaders, RequestHeaders, CookieHeaderValue
  • Microsoft.AspNetCore.Mvc.Abstractions - Validation types (IModelValidator, IClientModelValidator, ModelValidationContext, ClientModelValidationContext), ApiExplorer types (IApiDescriptionProvider, ApiDescription), ProblemDetails, Filter interfaces (IAsyncAuthorizationFilter, IFilterFactory, IOrderedFilter, IFilterMetadata, AuthorizationFilterContext, ActionConstraintContext)

Affected Projects (71 unique projects)

Round 1: Initial batch (26 projects)

  • HTTP: Http, Http.Results, Http.Extensions, Authentication.Core, Owin
  • Hosting: Hosting.Abstractions
  • Middleware: CORS, Diagnostics, HostFiltering, HttpOverrides, OutputCaching, StaticFiles, RequestDecompression, HeaderPropagation, HttpsPolicy, WebSockets
  • MVC: Mvc.Abstractions, Mvc.Core
  • Servers: Kestrel.Transport.Quic
  • Other: CookiePolicy, Http.Connections

Round 2: Second batch (11 projects)

  • Middleware: Rewrite, HealthChecks, ResponseCaching, ResponseCompression
  • Security: Authorization.Policy, Authentication (also fixed self-reference bug)
  • Servers: IISIntegration, Kestrel.Core
  • SignalR: SignalR.Core
  • Hosting: Hosting

Round 3: Third batch (9 projects)

  • Middleware: CookiePolicy, HostFiltering, WebSockets, HttpsPolicy, OutputCaching (added additional references)
  • Servers: Kestrel.Transport.Quic (added Http.Features)
  • Hosting: Hosting (added Hosting.Server.Abstractions)
  • Security: Authentication (added Authentication.Core)
  • SignalR: Http.Connections (added Authentication.Abstractions)

Round 4: Fourth batch (5 projects)

  • Servers: HttpSys, Kestrel, IIS
  • Hosting: TestHost

Round 5: Fifth batch (4 projects)

  • StaticAssets: StaticAssets
  • Servers: Kestrel, IIS (added additional references)
  • MVC: Mvc.Abstractions

Round 6: Sixth batch (2 projects)

  • MVC: Mvc.Core
  • DefaultBuilder: Microsoft.AspNetCore

Round 7: Seventh batch (3 projects)

  • MVC: Mvc.DataAnnotations
  • Hosting: TestHost (added Http)
  • SignalR: Http.Connections (added Http.Features)

Round 8: Eighth batch (1 project)

  • Middleware: HttpLogging

Round 9: Ninth batch (2 projects)

  • Middleware: RequestDecompression, Owin (added Http.Features)

Round 10: Tenth batch (3 projects)

  • Middleware: MiddlewareAnalysis
  • Azure: AzureAppServicesIntegration
  • Hosting: WindowsServices

Round 11: Eleventh batch (5 projects)

  • MVC: Mvc.ApiExplorer, Mvc.Formatters.Xml
  • Security: Authentication.Cookies, Authentication.BearerToken, Authentication.OAuth

Round 12: Twelfth batch (8 projects, additional references)

  • StaticAssets (added Http for IHttpActivityFeature)
  • DefaultBuilder (added Http for IHttpActivityFeature)
  • Mvc.Cors (added Mvc.Abstractions for filter types)
  • Mvc.Formatters.Xml (added Http for IHttpActivityFeature)
  • Mvc.ApiExplorer (added Http for IHttpActivityFeature)
  • Mvc.DataAnnotations (added Http.Abstractions for validation context)
  • Authentication.OAuth (added Http for IHttpActivityFeature)
  • Authentication.BearerToken (added Http for IHttpActivityFeature)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Dec 11, 2025
Open
@wtgodbe
Copy link
Member

wtgodbe commented Dec 11, 2025

@copilot correction: References should look like <Reference Include="Microsoft.AspNetCore.Http.Features" />

Copilot AI and others added 4 commits December 11, 2025 23:13
@wtgodbe
Add missing Reference elements to csproj files
dcbae2b 
Added Microsoft.AspNetCore.Http.Abstractions, Microsoft.AspNetCore.Http.Features, Microsoft.Extensions.Features, and Microsoft.AspNetCore.Hosting.Server.Abstractions references to projects that need them after dependency updates.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe
Add more missing Reference elements
53da7b4 
Added references to Microsoft.AspNetCore.Authentication.csproj and Microsoft.AspNetCore.Server.IISIntegration.csproj

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe
Add Microsoft.AspNetCore.Http.Abstractions to middleware and MVC proj…
79e31b3 
…ects

Added references to multiple middleware projects (CookiePolicy, RequestDecompression, HeaderPropagation, HttpsPolicy, WebSockets, ResponseCaching, ResponseCompression), MVC.Core, and SignalR Http.Connections.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe
Add Http.Features and Routing.Abstractions references
3c37155 
Added Microsoft.AspNetCore.Http.Features to CORS and Http.Results, and Microsoft.AspNetCore.Routing.Abstractions to Http.Results to resolve LinkGenerator type issues.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copilot AI changed the title [WIP] Update source code from dotnet/dotnet Add missing assembly references after dependency update to 11.0.0-alpha Dec 11, 2025
Copilot AI requested a review from wtgodbe December 11, 2025 23:24
@wtgodbe wtgodbe marked this pull request as ready for review December 11, 2025 23:26
@wtgodbe wtgodbe marked this pull request as draft December 11, 2025 23:27
@wtgodbe
Copy link
Member

wtgodbe commented Dec 11, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 11, 2025

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor Author

Copilot AI commented Dec 11, 2025

@copilot correction: References should look like <Reference Include="Microsoft.AspNetCore.Http.Features" />

Confirmed - all Reference elements added follow that format: <Reference Include="..." />

@wtgodbe
Copy link
Member

wtgodbe commented Dec 11, 2025

@copilot there are still more build errors to be fixed, as you can see in https://dev.azure.com/dnceng-public/public/_build/results?buildId=1228964&view=results. Please continue iterating by adding more References until they're all fixed.

Copilot AI and others added 2 commits December 11, 2025 23:45
@wtgodbe
Add missing references to Rewrite, StaticFiles, HealthChecks, Authori…
cfe3ee1 
…zation.Policy, ResponseCompression, and IISIntegration

Added Microsoft.AspNetCore.Http.Abstractions, Microsoft.AspNetCore.Http.Features, and Microsoft.AspNetCore.Authentication.Abstractions to projects that were missing them after dependency updates.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe
Add missing references to ResponseCaching and SignalR.Core
d41c445 
Added Microsoft.AspNetCore.Http.Features to ResponseCaching and Microsoft.AspNetCore.Http.Abstractions to SignalR.Core.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe
Add missing reference to HttpLogging
29a5201 
Added Microsoft.AspNetCore.Http.Features to HttpLogging for IHeaderDictionary, IHttpResponseBodyFeature, and IHttpUpgradeFeature.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot group the following errors by .csproj file. For each .csproj, add References to fix the errors.

...

Fixed HttpLogging errors by adding Microsoft.AspNetCore.Http.Features reference.

Microsoft.AspNetCore.HttpLogging.csproj - Added Microsoft.AspNetCore.Http.Features for:

  • IHeaderDictionary
  • IHttpResponseBodyFeature
  • IHttpUpgradeFeature

Commit: 29a5201

Total projects updated: 61

@wtgodbe

This comment was marked as resolved.

Sign in to view
@wtgodbe
Add missing references to RequestDecompression and Owin
56cbf5c 
Added Microsoft.AspNetCore.Http.Features to RequestDecompression and Owin.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot group the following errors by .csproj file. For each .csproj, add References to fix the errors.

2025-12-12T02:12:05.8880963Z D:\a_work\1\s\src\Middleware\RequestDecompression\src\DefaultR...

Fixed build errors by adding Microsoft.AspNetCore.Http.Features references:

Microsoft.AspNetCore.RequestDecompression.csproj - Added Microsoft.AspNetCore.Http.Features for:

  • IHeaderDictionary
  • IHttpMaxRequestBodySizeFeature

Microsoft.AspNetCore.Owin.csproj - Added Microsoft.AspNetCore.Http.Features for:

  • WebSocketAcceptContext

Commit: 56cbf5c

Total projects updated: 63

@wtgodbe
Copy link
Member

wtgodbe commented Dec 12, 2025

@copilot go through every .csproj in the repo, and add References to each to eliminate their build errors

Copilot AI and others added 2 commits December 12, 2025 04:57
@wtgodbe
Add missing reference to MiddlewareAnalysis
69e84eb 
Added Microsoft.AspNetCore.Http.Abstractions to MiddlewareAnalysis for IApplicationBuilder, RequestDelegate, and HttpContext.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe
Add missing references to AzureAppServicesIntegration and WindowsServ…
a8f8bbf 
…ices

Added Microsoft.AspNetCore.Hosting.Abstractions to both projects for IWebHostBuilder and IWebHost.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot go through every .csproj in the repo, and add References to each to eliminate their build errors

Systematically reviewing all .csproj files. Fixed 3 more source projects so far:

  • MiddlewareAnalysis (added Http.Abstractions)
  • AzureAppServicesIntegration (added Hosting.Abstractions)
  • WindowsServices (added Hosting.Abstractions)

Commits: 69e84eb, a8f8bbf

Total projects updated: 66

Continuing to search for and fix remaining build errors across all projects in the repository.

@wtgodbe
Copy link
Member

wtgodbe commented Dec 12, 2025

@copilot Add the missing References to the following projects to fix their build errors:

src/Mvc/Mvc.ApiExplorer/src/Microsoft.AspNetCore.Mvc.ApiExplorer.csproj
src/Security/Authentication/Cookies/src/Microsoft.AspNetCore.Authentication.Cookies.csproj
src/Security/Authentication/BearerToken/src/Microsoft.AspNetCore.Authentication.BearerToken.csproj
src/Security/Authentication/OAuth/src/Microsoft.AspNetCore.Authentication.OAuth.csproj
src/Mvc/Mvc.Formatters.Xml/src/Microsoft.AspNetCore.Mvc.Formatters.Xml.csproj

@wtgodbe
Add missing references to Mvc.ApiExplorer, Authentication projects, a…
926ff42 
…nd Mvc.Formatters.Xml

Added references to fix build errors:
- Mvc.ApiExplorer: Added Mvc.Abstractions
- Authentication.Cookies: Added Http.Abstractions, Net.Http.Headers
- Authentication.BearerToken: Added Http.Abstractions, Net.Http.Headers
- Authentication.OAuth: Added Http.Abstractions, WebUtilities, Authentication.Abstractions
- Mvc.Formatters.Xml: Added Mvc.Abstractions, WebUtilities

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot Add the missing References to the following projects to fix their build errors:

src/Mvc/Mvc.ApiExplorer/src/Microsoft.AspNetCore.Mvc.ApiExplorer.csproj
...

Fixed all 5 projects by adding missing references:

Mvc.ApiExplorer - Added Microsoft.AspNetCore.Mvc.Abstractions
Authentication.Cookies - Added Microsoft.AspNetCore.Http.Abstractions, Microsoft.Net.Http.Headers
Authentication.BearerToken - Added Microsoft.AspNetCore.Http.Abstractions, Microsoft.Net.Http.Headers
Authentication.OAuth - Added Microsoft.AspNetCore.Http.Abstractions, Microsoft.AspNetCore.WebUtilities, Microsoft.AspNetCore.Authentication.Abstractions
Mvc.Formatters.Xml - Added Microsoft.AspNetCore.Mvc.Abstractions, Microsoft.AspNetCore.WebUtilities

Commit: 926ff42

Total projects updated: 71

@wtgodbe
Copy link
Member

wtgodbe commented Dec 12, 2025

@copilot Add the missing References to the following projects to fix their build errors:

src/StaticAssets/src/Microsoft.AspNetCore.StaticAssets.csproj
src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
src/Mvc/Mvc.Formatters.Xml/src/Microsoft.AspNetCore.Mvc.Formatters.Xml.csproj
src/Mvc/Mvc.ApiExplorer/src/Microsoft.AspNetCore.Mvc.ApiExplorer.csproj
src/Mvc/Mvc.Cors/src/Microsoft.AspNetCore.Mvc.Cors.csproj
src/Mvc/Mvc.DataAnnotations/src/Microsoft.AspNetCore.Mvc.DataAnnotations.csproj
src/Security/Authentication/OAuth/src/Microsoft.AspNetCore.Authentication.OAuth.csproj
src/Security/Authentication/BearerToken/src/Microsoft.AspNetCore.Authentication.BearerToken.csproj

@wtgodbe
Add missing references to 8 projects for additional build error fixes
485f4f1 
Added Microsoft.AspNetCore.Http references and other missing dependencies:
- StaticAssets: Added Http
- DefaultBuilder: Added Http
- Mvc.Cors: Added Mvc.Abstractions
- Mvc.Formatters.Xml: Added Http
- Mvc.ApiExplorer: Added Http
- Mvc.DataAnnotations: Added Http.Abstractions
- Authentication.OAuth: Added Http
- Authentication.BearerToken: Added Http

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot Add the missing References to the following projects to fix their build errors:

src/StaticAssets/src/Microsoft.AspNetCore.StaticAssets.csproj
...

Fixed all 8 projects by adding missing references:

StaticAssets - Added Microsoft.AspNetCore.Http for IHttpActivityFeature, ResponseHeaders, RequestHeaders
DefaultBuilder - Added Microsoft.AspNetCore.Http for IHttpActivityFeature
Mvc.Formatters.Xml - Added Microsoft.AspNetCore.Http for IHttpActivityFeature
Mvc.ApiExplorer - Added Microsoft.AspNetCore.Http for IHttpActivityFeature
Mvc.Cors - Added Microsoft.AspNetCore.Mvc.Abstractions for filter interfaces (IAsyncAuthorizationFilter, IFilterFactory, IOrderedFilter, etc.)
Mvc.DataAnnotations - Added Microsoft.AspNetCore.Http.Abstractions for validation context types
Authentication.OAuth - Added Microsoft.AspNetCore.Http for IHttpActivityFeature
Authentication.BearerToken - Added Microsoft.AspNetCore.Http for IHttpActivityFeature

Commit: 485f4f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees

@wtgodbe wtgodbe

Copilot code review Copilot

Labels

Attention: Shared Code Modified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @ilonatommy