Fix exit code handling in runtests.cmd #64820
Merged
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were inadvertently setting exit code = 0 even if a test failed. This is because the way the `errorlevel` command works is that it checks whether the last command exit code was **greater than or equal** to the argument. So checking `errorlevel 0` in the if reports true even when we have exit code 1 and then we negate that and don't enter the if block. We don't actually need this if check at all since we just want to print the value.
github-actions
bot
added
the
needs-area-label
akoeplinger
added
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the Helix test runner script where test failures were incorrectly reported as successes. The issue was caused by misusing the errorlevel command in batch files, which performs a "greater than or equal" comparison rather than an equality check.
Key changes:
- Removed the faulty
if not errorlevel 0conditional that always evaluated to false - Simplified exit code capture to directly use the
%errorlevel%variable - Eliminated unnecessary initialization of
exit_code=0
ilonatommy
approved these changes
Dec 19, 2025
maraf
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were inadvertently setting exit code = 0 even if a test failed.
This is because the way the
errorlevelcommand works is that it checks whether the last command exit code was greater than or equal to the argument.So checking
errorlevel 0in the if reports true even when we have exit code 1 and then we negate that and don't enter the if block.We don't actually need this if check at all since we just want to print the value so we can just capture the
%errorlevel%variable.