Skip to content

[release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument#65331

Merged
wtgodbe merged 2 commits intorelease/8.0from
wtgodbe/GetDocument8
Feb 5, 2026
Merged

[release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument#65331
wtgodbe merged 2 commits intorelease/8.0from
wtgodbe/GetDocument8

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 4, 2026

Backport of #64351, fixes a CG alert

Copilot AI review requested due to automatic review settings February 4, 2026 22:48
@wtgodbe wtgodbe changed the title Don't use netcoreapp2.1 in dotnet-getdocument [release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument Feb 4, 2026
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes support for netcoreapp2.1, an unsupported framework, from the dotnet-getdocument and related tools. This is a backport to release/8.0 of PR #64351 that addresses a Component Governance alert.

Changes:

  • Removed netcoreapp2.1 from TargetFrameworks in three project files
  • Simplified version detection logic in InvokeCommand.cs to use a uniform path construction approach
  • Updated NuGet package specification to reference net8.0 instead of netcoreapp2.1

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj Removed netcoreapp2.1 from TargetFrameworks
src/Tools/dotnet-getdocument/src/Commands/InvokeCommand.cs Simplified framework version logic by removing special case for versions >= 7.0 and obsolete netcoreapp2.1 fallback
src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj Removed netcoreapp2.1 from TargetFrameworks and its specific package dependency
src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.nuspec Updated file paths from netcoreapp2.1 to net8.0
src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj Removed netcoreapp2.1 from TargetFrameworks

@wtgodbe wtgodbe merged commit f48b92a into release/8.0 Feb 5, 2026
30 of 31 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/GetDocument8 branch February 5, 2026 00:40
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.25 Feb 5, 2026
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Feb 5, 2026
This was referenced Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants