Deflake HttpStream pooling tests#65356
Merged
Merged
Conversation
github-actions
Bot
added
the
area-networking
adityamandaleeka
approved these changes
Feb 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deflakes Kestrel HTTP/2 stream pooling functional tests by ensuring stream completion is observed before triggering the pool maintenance tick, eliminating a race where completed streams weren’t yet eligible to be returned to the pool.
Changes:
- Add
WaitForAllStreamsAsync()beforeTriggerTick()in several StreamPool-related tests to ensureOnStreamCompletedhas run and streams are eligible for pooling.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: After
serverTcs.SetResult(), the echo app delegate runs asynchronously. The test immediately calledTriggerTick()+ assertedStreamPool.Count == 1, but the stream hadn't completed yet (OnStreamCompletedhadn'tenqueued it to
_completedStreams). The sibling testStreamPool_MultipleStreamsConcurrent_StreamsReturnedToPoolalready uses
WaitForAllStreamsAsync()beforeTriggerTick()to avoid this race. (see #57473)