Skip to content

Fix race in RST_STREAM_IncompleteRequest_AdditionalResetFrame test #65715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 2 commits into from
Mar 10, 2026
Merged

Fix race in RST_STREAM_IncompleteRequest_AdditionalResetFrame test #65715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c847a6
Fix race in RST_STREAM_IncompleteRequest_AdditionalResetFrame test
lewing Mar 9, 2026
76dd35e
Fix RST_STREAM additional reset test ordering
lewing Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3588,6 +3588,7 @@ await WaitForConnectionErrorAsync<Http2ConnectionErrorException>(ignoreNonGoAway
[Fact]
public async Task RST_STREAM_IncompleteRequest_AdditionalResetFrame_IgnoreAdditionalReset()
{
var abortedTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

var headers = new[]
Expand All @@ -3596,13 +3597,20 @@ public async Task RST_STREAM_IncompleteRequest_AdditionalResetFrame_IgnoreAdditi
new KeyValuePair<string, string>(InternalHeaderNames.Path, "/"),
new KeyValuePair<string, string>(InternalHeaderNames.Scheme, "http"),
};
await InitializeConnectionAsync(context => tcs.Task);
await InitializeConnectionAsync(context =>
{
context.RequestAborted.Register(() => abortedTcs.TrySetResult());
return tcs.Task;
});

await StartStreamAsync(1, headers, endStream: false);
await SendDataAsync(1, new byte[1], endStream: false);
await SendRstStreamAsync(1);
await SendRstStreamAsync(1);
tcs.TrySetResult();

await abortedTcs.Task;

tcs.TrySetResult(); // Don't let the response start until after the request aborts

await StopConnectionAsync(expectedLastStreamId: 1, ignoreNonGoAwayFrames: false);

Expand Down
Loading