Skip to content

Unquarantine RoutePatternCompletionProviderTests#65782

Merged
ilonatommy merged 1 commit into
mainfrom
fix/unquarantine-fixed-tests
Mar 16, 2026
Merged

Unquarantine RoutePatternCompletionProviderTests#65782
ilonatommy merged 1 commit into
mainfrom
fix/unquarantine-fixed-tests

Conversation

@lewing
Copy link
Copy Markdown
Member

@lewing lewing commented Mar 15, 2026

The Roslyn upgrade that caused RoutePatternCompletionProviderTests to fail (#49126) was resolved and the issue was closed in Aug 2024, but the [QuarantinedTest] attribute was never removed.

This PR removes it so these tests run in CI again.

The Roslyn upgrade that caused these tests to fail (#49126) has been
resolved. The tracking issue was closed in Aug 2024 but the quarantine
attribute was never removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 15, 2026 03:14
@github-actions github-actions Bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Mar 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the [QuarantinedTest] attribute from RoutePatternCompletionProviderTests so these tests run in CI again, since the underlying Roslyn issue (#49126) was resolved.

Changes:

  • Removed [QuarantinedTest] attribute and its associated using Microsoft.AspNetCore.InternalTesting directive

You can also share your feedback on Copilot code review. Take the survey.

@lewing lewing added area-routing and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Mar 15, 2026
@lewing lewing requested a review from ilonatommy March 16, 2026 14:05
@ilonatommy ilonatommy merged commit dedf040 into main Mar 16, 2026
31 checks passed
@ilonatommy ilonatommy deleted the fix/unquarantine-fixed-tests branch March 16, 2026 14:08
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview3 milestone Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants